Closed wallner closed 8 years ago
I think you forgot to extend the methods for groups in org.osiam.client.OsiamConnector
with the attributes
argument.
Please, also update the changelog.
Please, also update the missing part in the release announcement.
When do you think, are you able to write some ITs?
I'm going to write two ITs once this is merged.
Please fix the last 4 comments and then this is ready to go.
The Circle CI build is failing, but I cannot rebuild it, because it's contained in your private user namespace. Did you connect your fork with Circle CI? If so, please remove your fork from Circle CI, so that your PRs build under the OSIAM namespace again.
I cannot build, license headers are missing for src/main/java/org/osiam/client/OsiamConnector.java
:
$ mvn clean test
…
[INFO]
[INFO] --- license-maven-plugin:2.11:check (default) @ connector4java ---
[INFO] Checking licenses...
[WARNING] Missing header in: /home/thomas/Source/Osiam/connector4java/src/main/java/org/osiam/client/OsiamConnector.java
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
…
Did you remove them?!
Oh, auto formatter treated it like a javadoc comment, the old problem :(
Thank you very much.
This pull request adds the option of filtering of the attributes of the resources returned by queries.
Resolves #220