Implemented ignoring invalid quote chars - but valid quote chars on last buffer position don't work yet - Githubissues

osiegmar / FastCSV

CSV library for Java that is fast, RFC-compliant and dependency-free.

https://fastcsv.org/

MIT License

542 stars 93 forks source link

Implemented ignoring invalid quote chars - but valid quote chars on last buffer position don't work yet #75

Closed dankito closed 1 year ago

dankito commented 1 year ago

Fixes

Proposed Changes

If ignoreInvalidQuoteChars is set to true invalid quote chars as in "de:14628:1148:1";"Ri. "Am Windberg"";"51,002455" are passed to the output (and no exception gets thrown).

Performance

In order to prevent a performance degradation please run a benchmark using ./gradlew jmh before and after your change and show the results.

Before:

Benchmark                     Mode  Cnt        Score        Error  Units
FastCsvReadBenchmark.read    thrpt   10  1987327.151 ± 540067.157  ops/s
FastCsvWriteBenchmark.write  thrpt   10  2841910.312 ±  52620.092  ops/s

After:


Benchmark                     Mode  Cnt        Score        Error  Units
FastCsvReadBenchmark.read    thrpt   10  2043698.557 ± 126276.985  ops/s
FastCsvWriteBenchmark.write  thrpt   10  2970970.969 ± 261846.346  ops/s

osiegmar commented 1 year ago

See #74