search

osiegmar / FastCSV

CSV library for Java that is fast, RFC-compliant and dependency-free.
https://fastcsv.org/
MIT License
542 stars 93 forks source link

remove getters #86

Closed osiegmar closed 10 months ago

osiegmar commented 1 year ago

Please create PR against the develop branch

This PR relates to Issue: #

Proposed Changes

-

-

Performance

In order to prevent a performance degradation please run a benchmark using ./gradlew jmh before and after your change and show the results.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (831047e) 100.00% compared to head (ac1ed67) 100.00%. Report is 18 commits behind head on develop.

:exclamation: Current head ac1ed67 differs from pull request most recent head f4d71fb. Consider uploading reports for the commit f4d71fb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #86 +/- ## ============================================ Coverage 100.00% 100.00% - Complexity 194 296 +102 ============================================ Files 13 21 +8 Lines 653 942 +289 Branches 95 128 +33 ============================================ + Hits 653 942 +289 ``` | [Files](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar) | Coverage Δ | | |---|---|---| | [...a/de/siegmar/fastcsv/reader/ByteChannelStream.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0J5dGVDaGFubmVsU3RyZWFtLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...egmar/fastcsv/reader/CollectingStatusListener.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NvbGxlY3RpbmdTdGF0dXNMaXN0ZW5lci5qYXZh) | `100.00% <100.00%> (ø)` | | | [.../main/java/de/siegmar/fastcsv/reader/CsvIndex.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NzdkluZGV4LmphdmE=) | `100.00% <100.00%> (ø)` | | | [...main/java/de/siegmar/fastcsv/reader/CsvReader.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NzdlJlYWRlci5qYXZh) | `100.00% <100.00%> (ø)` | | | [...main/java/de/siegmar/fastcsv/reader/CsvRecord.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NzdlJlY29yZC5qYXZh) | `100.00% <100.00%> (ø)` | | | [...e/siegmar/fastcsv/reader/CsvRecordSpliterator.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NzdlJlY29yZFNwbGl0ZXJhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...ain/java/de/siegmar/fastcsv/reader/CsvScanner.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0NzdlNjYW5uZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...va/de/siegmar/fastcsv/reader/IndexedCsvReader.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL0luZGV4ZWRDc3ZSZWFkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...java/de/siegmar/fastcsv/reader/NamedCsvReader.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL05hbWVkQ3N2UmVhZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...java/de/siegmar/fastcsv/reader/NamedCsvRecord.java](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar#diff-c3JjL21haW4vamF2YS9kZS9zaWVnbWFyL2Zhc3Rjc3YvcmVhZGVyL05hbWVkQ3N2UmVjb3JkLmphdmE=) | `100.00% <100.00%> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/osiegmar/FastCSV/pull/86?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Siegmar) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.