search

osiegmar / FastCSV

CSV library for Java that is fast, RFC-compliant and dependency-free.
https://fastcsv.org/
MIT License
542 stars 93 forks source link

Suggestion for using bnd plugin for JPMS and OSGi Metadata #92

Closed juergen-albert closed 10 months ago

juergen-albert commented 10 months ago

As discussed in PR https://github.com/osiegmar/FastCSV/pull/89 here is a Version that takes care of the JPMS stuff.

I have no real clue about gradle, so I only cargo culted that part. Thus there may be more elegent solutions. It also only works for the lib main project and as fas as I can see non of the others.

The Manifest result is:

image

The Module info now only exists as a compiled class file:

image

But you can see, that it now also references correctly the required java modules for you, which is nice for jlink. You can get fancy with JPMS if you like and use additional Annotations or an instruction: https://bnd.bndtools.org/chapters/330-jpms.html

osiegmar commented 10 months ago

Thanks! I'll give it a spin.

juergen-albert commented 10 months ago

Thanks. If you have questions, feel free to get in touch or ask here: https://bnd.discourse.group/

stbischof commented 7 months ago

@juergen-albert Thanks!!!