osinfra-io / google-cloud-kubernetes

Infrastructure as Code (IaC) example for Google Cloud Platform Kubernetes resources.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Remove Istio primary remote references #109

Closed brettcurtis closed 4 weeks ago

brettcurtis commented 1 month ago

Summary by CodeRabbit

infracost[bot] commented 1 month ago

💰 Infracost report

This pull request is aligned with your company's FinOps policies and the Well-Architected Framework.

🟢 This pull request fixes 4 pre-existing issues in the default branch - Default `4 issues`
Monthly estimate increased by $25 📈
Changed project Baseline cost Usage cost* Total change New monthly cost
main-sandbox +$0 +$25 +$25 (+201%) $37
*Usage costs were estimated using [Infracost Cloud settings](https://dashboard.infracost.io/org/osinfra-io/settings/usage-defaults), see [docs](https://www.infracost.io/docs/features/usage_based_resources/#infracost-usageyml) for other options.
Estimate details (includes details of unsupported resources) ``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: main-sandbox + module.datadog[0].google_pubsub_subscription.integration +$15 + Message delivery data +$5, +0.125 TiB* + Retained acknowledged message storage +$5, +18 GiB* + Snapshot message backlog storage +$5, +18 GiB* + module.datadog[0].google_logging_project_sink.integration +$5 + Logging data +$5, +10 GB* + module.datadog[0].google_pubsub_topic.integration +$5 + Message ingestion data +$5, +0.125 TiB* Monthly cost change for main-sandbox Amount: +$25 ($12 → $37) Percent: +201% ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed 13 projects have no cost estimate changes. Run the following command to see their breakdown: infracost breakdown --path=/path/to/code ────────────────────────────────── *Usage costs were estimated using Infracost Cloud settings, see docs for other options. 141 cloud resources were detected: ∙ 19 were estimated ∙ 112 were free ∙ 10 are not supported yet, see https://infracost.io/requested-resources: ∙ 4 x google_gke_hub_feature ∙ 2 x google_billing_budget ∙ 2 x google_compute_security_policy ∙ 2 x google_gke_hub_membership ```

This comment will be updated when code changes.

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes encompass updates to version specifications across multiple Terraform configuration files. Key modifications include incrementing the versions of various modules and providers, particularly the Google provider, and transitioning specific modules to designated branches. Additionally, certain input parameters have been removed from the documentation, indicating a refinement in the configuration options available.

Changes

Files Change Summary
.pre-commit-config.yaml Updated versions for pre-commit-terraform (v1.94.1) and checkov (3.2.239).
README.md, regional/datadog/README.md, regional/istio/README.md, regional/onboarding/README.md Updated kubernetes_istio module version to brettcurtis%2Fissue2, project to v0.3.1, and Google provider version from 5.40.0 to 6.0.1.
main.tf, regional/datadog/main.tf, regional/istio/main.tf, regional/istio/manifests/main.tf Changed source for kubernetes_istio and kubernetes_datadog_operator modules to specific branches.
regional/.terraform.lock.hcl Updated google and google-beta provider versions from 5.42.0 and 5.40.0 to 6.0.1.
regional/datadog/manifests/README.md, regional/istio/manifests/README.md Updated sources for kubernetes_datadog_operator_manifests to limits and kubernetes_istio_manifests to brettcurtis%2Fissue2.

Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.