Enable cluster - Githubissues

brettcurtis commented 10 months ago

Summary by CodeRabbit

New Features
- Introduced documentation for Terraform global and regional infrastructure setups, detailing modules, inputs, and outputs.
- Added new configurations for Istio gateway DNS settings across different environments.
- Implemented Terraform configurations for managing Google Kubernetes Engine with Istio integration and multi-cluster ingress setups.
- Added resource usage estimates configuration files for Infracost across various environments and regions.
Enhancements
- Updated job names and configurations in GitHub workflows for clarity and consistency.
- Upgraded the version of the pre-commit-terraform repository and Terraform provider for Google.
- Enhanced Terraform configurations with new variables for enabling Datadog integration, Istio gateway DNS, and Google service accounts.
- Updated Terraform configurations for regional infrastructure, including renaming modules and variables.
Bug Fixes
- Adjusted job dependencies and configurations in GitHub workflows for improved reliability.
Documentation
- Added comprehensive README files for global and regional infrastructure setups.
Refactor
- Renamed Terraform variables and modules for improved clarity and consistency.

coderabbitai[bot] commented 10 months ago

Walkthrough

This comprehensive update streamlines the deployment and management of Kubernetes clusters and Istio on Google Cloud, enhancing configurations and dependencies across global and regional setups. It simplifies the onboarding process, reduces complexity in managing multiple repositories, and improves workflows for platform developers, directly addressing key objectives for a more efficient infrastructure management experience.

Changes

Files	Change Summary
`.github/workflows/sandbox.yml`	Renamed jobs for clarity, added Multi-cluster Ingress and Istio setups, adjusted dependencies and configurations.
`.pre-commit-config.yaml`	Updated `pre-commit-terraform` to `v1.88.3`.
`global/...`, `regional/...` (various)	Introduced and updated configurations for Terraform global and regional infrastructure, including Istio setup, GKE configurations, and backend sharing. Enhanced documentation and added new variables for better customization and integration.
`infracost.yml`, `regional/istio/infracost/...`	Restructured for regional Istio deployments, with detailed resource usage estimates for Infracost calculations.
`shared/tfvars/...`	Updated configurations for namespace settings, including service accounts and Istio injection.

Related issues

osinfra-io/platform-google-cloud-kubernetes#1: This PR directly addresses the objectives by simplifying the onboarding process, reducing complexity, and improving workflows for platform developers, which are key objectives outlined in the issue.
osinfra-io/github-organization-discussions#6: The changes in this PR contribute to simplifying the onboarding process and managing dependencies across multiple repositories, aligning with the objectives of enhancing workflows and streamlining resource management.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

infracost[bot] commented 10 months ago

Infracost report

💰 Monthly cost will increase by $44 📈

Project	Cost change	New monthly cost
regional/istio: us-east1-non-production	+$7	$7
regional/istio: us-east1-production	+$7	$7
regional/istio: us-east1-sandbox	+$7	$7
regional/istio: us-east4-non-production	+$7	$7
regional/istio: us-east4-production	+$7	$7
regional/istio: us-east4-sandbox	+$7	$7

Cost details

``` ────────────────────────────────── Project: regional/istio: us-east1-non-production Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east1.nonprod.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east1-non-production (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: regional/istio: us-east1-production Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east1.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east1-production (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: regional/istio: us-east1-sandbox Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east1.sb.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east1-sandbox (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: regional/istio: us-east4-non-production Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east4.nonprod.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east4-non-production (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: regional/istio: us-east4-production Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east4.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east4-production (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: regional/istio: us-east4-sandbox Module path: regional/istio + module.kubernetes_engine_istio.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.kubernetes_engine_istio.google_dns_record_set.istio_gateway["us-east4.sb.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for regional/istio: us-east4-sandbox (Module path: regional/istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: global/infra: non-production Module path: global/infra Errors: Error loading Terraform modules: could not load modules for path global/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/global/onboarding: no such file or directory ────────────────────────────────── Project: global/infra: production Module path: global/infra Errors: Error loading Terraform modules: could not load modules for path global/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/global/onboarding: no such file or directory ────────────────────────────────── Project: global/infra: sandbox Module path: global/infra Errors: Error loading Terraform modules: could not load modules for path global/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/global/onboarding: no such file or directory ────────────────────────────────── Project: regional/infra: us-east1-non-production Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Project: regional/infra: us-east1-production Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Project: regional/infra: us-east1-sandbox Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Project: regional/infra: us-east4-non-production Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Project: regional/infra: us-east4-production Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Project: regional/infra: us-east4-sandbox Module path: regional/infra Errors: Error loading Terraform modules: could not load modules for path regional/infra open .infracost/terraform_modules/c960d4b231da0a39458b24164e325ac6/regional/infra: no such file or directory ────────────────────────────────── Key: ~ changed, + added, - removed 12 cloud resources were detected: ∙ 12 were estimated Infracost estimate: Monthly cost will increase by $44 ↑ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓ ┃ Project ┃ Cost change ┃ New monthly cost ┃ ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━┫ ┃ regional/istio: us-east1-non-production ┃ +$7 ┃ $7 ┃ ┃ regional/istio: us-east1-production ┃ +$7 ┃ $7 ┃ ┃ regional/istio: us-east1-sandbox ┃ +$7 ┃ $7 ┃ ┃ regional/istio: us-east4-non-production ┃ +$7 ┃ $7 ┃ ┃ regional/istio: us-east4-production ┃ +$7 ┃ $7 ┃ ┃ regional/istio: us-east4-sandbox ┃ +$7 ┃ $7 ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━━━━┛ ```

Governance checks

🟢 52 passed

50 FinOps policies, 1 Tagging policy, and 1 Guardrail passed.

_{View report in Infracost Cloud. This comment will be updated when code changes.}

osinfra-io / google-cloud-kubernetes

Enable cluster #15