Alignment across repositories

brettcurtis commented 6 months ago

Summary by CodeRabbit

New Features
- Enabled Datadog monitoring and logging by default in sandbox environments.
- Introduced a more detailed labeling system across resources for better management and cost attribution.
Documentation
- Updated all README.md files to include more current information, emojis for better engagement, and clarified Terraform documentation.
- Renamed several documentation sections to better reflect their content.
Refactor
- Updated Terraform provider versions to improve stability and feature support.
- Simplified Terraform configurations by standardizing on project instead of project_id and reorganizing module configurations.
Chores
- Removed global workflow definitions that were not necessary.
- Updated pre-commit hooks to enhance code quality checks.

coderabbitai[bot] commented 6 months ago

Walkthrough

## Walkthrough The series of changes across various files primarily involve updates to Terraform configurations and documentation. These updates include version bumps for the Google provider, modifications to label definitions and project references, enhancements to monitoring and logging through Datadog integration, and a general cleanup of workflow definitions and pre-commit hooks. The changes aim to standardize project configurations, improve infrastructure management, and ensure up-to-date documentation and tooling compatibility. ## Changes | File Path | Change Summary | |--------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `.github/workflows/sandbox-destroy.yml` | Removed global workflow definition including Terraform execution details for destroying resources in a sandbox environment. | | `.pre-commit-config.yaml` | Removed `infracost_generate_config` and `infracost_breakdown` hooks; updated `pre-commit-terraform` to `v1.88.4`; added comment for `terraform_docs` to run after `terraform_validate`. | | `README.md`, `global/README.md`, `regional/.../README.md` | Added emoji to repository description; modified link text for local development setup; updated Terraform documentation and version references; renamed documentation and clarified descriptions. | | `global/.terraform.lock.hcl`, `regional/.../.terraform.lock.hcl` | Updated Google provider version from "5.21.0" to "5.22.0" and updated hashes. | | `global/locals.tf`, `regional/locals.tf` | Added `labels` block with key-value pairs for `cost-center`, `env`, `repository`, `platform`, and `team`. | | `global/main.tf`, `regional/main.tf`, `regional/istio/main.tf`, `regional/mci/main.tf`, `regional/onboarding/main.tf` | Added `labels` and `project` declarations; removed specific label assignments; changed `project_id` to `project`; updated module versions and references. | | `global/tfvars/sandbox.tfvars` | Enabled Datadog by setting `enable_datadog` to `true`. |

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

infracost[bot] commented 6 months ago

💰 Infracost report

Monthly cost will increase by $25 📈

Changed project	Baseline cost	Usage cost*	Total change	New monthly cost
global-sandbox	+$0	+$25 (+494%)	+$25 (+201%)	$37

*Usage costs were estimated with usage defaults, which can also be overridden in the config files.

Cost details (includes details of unsupported resources)

``` ────────────────────────────────── Project: global-sandbox Module path: global + module.datadog[0].google_pubsub_subscription.integration +$15 + Message delivery data +$5, +0.125 TiB* + Retained acknowledged message storage +$5, +18 GiB* + Snapshot message backlog storage +$5, +18 GiB* + module.datadog[0].google_logging_project_sink.integration +$5 + Logging data +$5, +10 GB* + module.datadog[0].google_pubsub_topic.integration +$5 + Message ingestion data +$5, +0.125 TiB* Monthly cost change for global-sandbox (Module path: global) Amount: +$25 ($12 → $37) Percent: +201% ────────────────────────────────── Key: ~ changed, + added, - removed *Usage costs were estimated with usage defaults from Infracost Cloud, which can also be overridden in the config files. 137 cloud resources were detected: ∙ 17 were estimated ∙ 112 were free ∙ 8 are not supported yet, rerun with --show-skipped to see details Infracost estimate: Monthly cost will increase by $25 ↑ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Changed project ┃ Baseline cost ┃ Usage cost ┃ Total change ┃ ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫ ┃ global-sandbox ┃ +$0 ┃ +$25 (+494%) ┃ +$25 (+201%) ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛ ```

Governance checks

🟢 52 passed

50 FinOps policies, 1 Tagging policy, and 1 Guardrail passed.

_{View report in Infracost Cloud. This comment will be updated when code changes.}

osinfra-io / google-cloud-kubernetes