osinfra-io / google-cloud-kubernetes

Infrastructure as Code (IaC) example for Google Cloud Platform Kubernetes resources.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Disable Datadog #46

Closed brettcurtis closed 7 months ago

coderabbitai[bot] commented 7 months ago
Walkthrough ## Walkthrough The recent updates primarily focus on version upgrades and configuration adjustments across various components. Notably, there's a shift in the Terraform Google provider versions from 5.22.0 to 5.24.0, alongside updates to other providers like helm and kubernetes, reflecting a stride towards maintaining up-to-date dependencies. Furthermore, adjustments in configurations, such as the disabling of Datadog integration and modification in billing account settings, indicate refinements aimed at optimizing operational aspects and cost management. ## Changes | Files | Change Summary | |-------|----------------| | `.github/workflows/sandbox.yml` | Removed `-var=billing_account` argument from `terraform_plan_secret_args`. | | `.pre-commit-config.yaml` | Updated `pre-commit/pre-commit-hooks` revision from `v4.5.0` to `v4.6.0`. | | `global/.../.terraform.lock.hcl`, `global/README.md`, `global/tfvars/sandbox.tfvars`, `global/variables.tf` | Updated Google provider version to `5.24.0`, changed `billing_account` default value, and toggled `enable_datadog` to `false`. | | `regional/.../.terraform.lock.hcl`, `regional/istio/...`, `regional/mci/...`, `regional/onboarding/...` | Updated versions for Google, helm, and Kubernetes providers across regional configurations. Adjusted corresponding hashes and documentation to reflect new provider versions. |

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between b41bb6891c69e91781431b5ca80450aab31bec66 and 64be76e602cd4a0fbcbc6e84be5f681319bb5250.
Files selected for processing (13) * .github/workflows/sandbox.yml (1 hunks) * .pre-commit-config.yaml (1 hunks) * global/.terraform.lock.hcl (1 hunks) * global/README.md (1 hunks) * global/tfvars/sandbox.tfvars (1 hunks) * global/variables.tf (1 hunks) * regional/.terraform.lock.hcl (1 hunks) * regional/istio/.terraform.lock.hcl (1 hunks) * regional/istio/README.md (1 hunks) * regional/mci/.terraform.lock.hcl (1 hunks) * regional/mci/README.md (1 hunks) * regional/onboarding/.terraform.lock.hcl (1 hunks) * regional/onboarding/README.md (1 hunks)
Additional comments not posted (18)
global/tfvars/sandbox.tfvars (1)
`2-2`: Disabling Datadog integration as intended.
.pre-commit-config.yaml (1)
`6-6`: Updated pre-commit hooks to the latest version.
global/variables.tf (1)
`7-7`: Updated default value for `billing_account` to provide clearer configuration guidance.
regional/mci/README.md (1)
`12-12`: Updated `google` provider version in documentation to match the current requirement.
regional/istio/README.md (1)
`12-12`: Updated `google` provider version in documentation to match the current requirement.
regional/onboarding/README.md (1)
`12-12`: Updated `google` provider version in documentation to match the current requirement.
regional/mci/.terraform.lock.hcl (2)
`5-18`: Updated `google` provider version and hashes as intended. --- `24-38`: Updated `kubernetes` provider version and hashes as intended.
regional/onboarding/.terraform.lock.hcl (2)
`5-18`: Updated `google` provider version and hashes as intended. --- `24-38`: Updated `kubernetes` provider version and hashes as intended.
regional/.terraform.lock.hcl (2)
`5-18`: Version update for `hashicorp/google` to `5.24.0` looks good. --- `24-37`: Version update for `hashicorp/google-beta` to `5.24.0` looks good.
regional/istio/.terraform.lock.hcl (3)
`5-18`: Version update for `hashicorp/google` to `5.24.0` looks good. --- `24-37`: Version update for `hashicorp/helm` to `2.13.0` looks good. --- `43-57`: Version update for `hashicorp/kubernetes` to `2.28.1` looks good.
global/.terraform.lock.hcl (1)
`26-39`: Version update for `hashicorp/google` to `5.24.0` looks good.
global/README.md (1)
`28-28`: Update of default value for `billing_account` to `"01C550-A2C86B-B8F16B"` enhances documentation clarity.
.github/workflows/sandbox.yml (1)
Line range hint `28-28`: Removal of `-var=billing_account=${{ secrets.BILLING_ACCOUNT }}` from `terraform_plan_secret_args` aligns with workflow configuration updates.
---
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
infracost[bot] commented 7 months ago

💰 Infracost report

Monthly cost will decrease by $25 📉

Changed project Baseline cost Usage cost* Total change New monthly cost
global-sandbox +$0 -$25 -$25 (-67%) $12

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Cost details (includes details of unsupported resources) ``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: global-sandbox Module path: global - module.datadog[0].google_logging_project_sink.integration -$5 - Logging data -$5, -10 GB* - module.datadog[0].google_pubsub_topic.integration -$5 - Message ingestion data -$5, -0.125 TiB* - module.datadog[0].google_pubsub_subscription.integration -$15 - Message delivery data -$5, -0.125 TiB* - Retained acknowledged message storage -$5, -18 GiB* - Snapshot message backlog storage -$5, -18 GiB* Monthly cost change for global-sandbox (Module path: global) Amount: -$25 ($37 → $12) Percent: -67% ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed 10 projects have no cost estimate changes. Run the following command to see their breakdown: infracost breakdown --path=/path/to/code ────────────────────────────────── *Usage costs were estimated using Infracost Cloud settings, see docs for other options. 126 cloud resources were detected: ∙ 14 were estimated ∙ 104 were free ∙ 8 are not supported yet, see https://infracost.io/requested-resources: ∙ 4 x google_gke_hub_feature ∙ 2 x google_billing_budget ∙ 2 x google_gke_hub_membership Infracost estimate: Monthly cost will decrease by $25 ↓ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Changed project ┃ Baseline cost ┃ Usage cost ┃ Total change ┃ ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫ ┃ global-sandbox ┃ +$0 ┃ -$25 ┃ -$25 (-67%) ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛ ```

Governance checks

🟢 54 passed
52 FinOps policies, 1 Tagging policy, and 1 Guardrail passed.

View report in Infracost Cloud. This comment will be updated when code changes.