search

osinfra-io / google-cloud-kubernetes

Infrastructure as Code (IaC) example for Google Cloud Platform Kubernetes resources.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Align workflow names #72

Closed brettcurtis closed 1 month ago

brettcurtis commented 1 month ago

Summary by CodeRabbit

infracost[bot] commented 1 month ago

💰 Infracost report

Consider fixing these issues, they don't align with your company's FinOps policies & the Well-Architected Framework.

Tagging policies
❌ Default
resource [google_compute_global_address.istio_gateway[0]](https://github.com/osinfra-io/terraform-kubernetes-istio/blob/HEAD/regional/main.tf#L73) provisioned by module [module.kubernetes_istio](https://github.com/osinfra-io/google-cloud-kubernetes/blob/af02ffb68b056c82ca202e3dbe2b7c105e9d361c/regional/istio/main.tf#L73) * Missing mandatory tags: ` team `, ` cost-center `, ` env `, ` repository `. Consider using default tags to avoid adding tags to individual resources. in projects ` regional-istio-production `, ` regional-istio-sandbox `
resource [google_compute_global_address.istio_gateway_mci[0]](https://github.com/osinfra-io/terraform-kubernetes-istio/blob/HEAD/main.tf#L92) provisioned by module [module.kubernetes_istio](https://github.com/osinfra-io/google-cloud-kubernetes/blob/af02ffb68b056c82ca202e3dbe2b7c105e9d361c/main.tf#L92) * Missing mandatory tags: ` team `, ` cost-center `, ` env `, ` repository `. Consider using default tags to avoid adding tags to individual resources. in projects ` main-production `, ` main-sandbox `
Monthly estimate generated
Estimate details (includes details of unsupported resources) ``` ────────────────────────────────── 12 projects have no cost estimate changes. Run the following command to see their breakdown: infracost breakdown --path=/path/to/code ────────────────────────────────── 129 cloud resources were detected: ∙ 16 were estimated ∙ 104 were free ∙ 9 are not supported yet, see https://infracost.io/requested-resources: ∙ 4 x google_gke_hub_feature ∙ 3 x google_gke_hub_membership ∙ 2 x google_billing_budget ```

This comment will be updated when code changes.

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent modifications represent a significant renaming effort throughout the configuration files, primarily transitioning identifiers from "global" to "main." This strategic shift enhances clarity and consistency within the Terraform and GitHub Actions workflows, effectively aligning naming conventions with their intended purpose. The updates encompass job identifiers, data source references, and variable declarations, thereby fostering a more organized and intuitive infrastructure management structure.

Changes

Files Change Summary
.github/workflows/sandbox.yml Renamed job from global to main, updated parameters github_environment and terraform_workspace accordingly.
.pre-commit-config.yaml Updated versions of pre-commit-terraform and checkov to newer releases.
regional/README.md, regional/mci/README.md, regional/onboarding/README.md Changed references from terraform_remote_state.global to terraform_remote_state.main for consistency in documentation.
regional/locals.tf, regional/mci/locals.tf Renamed local variable from global to main, updating references to their respective outputs.
regional/main.tf, regional/mci/main.tf, regional/onboarding/main.tf Updated terraform_remote_state data source and associated workspace naming from global to main, reflecting new conventions.
regional/outputs.tf Changed project_id output source from local.global.project_id to local.main.project_id.
shared/tfvars/non-production.tfvars, shared/tfvars/production.tfvars, shared/tfvars/sandbox.tfvars Removed namespace configurations for backstage, istio-ingress, and istio-system, indicating a shift in namespace management.
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.