search

osinfra-io / terraform-datadog-google-integration

Terraform example module for Datadog Google Cloud Platform integration.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Empty tuple for `google_bigquery_dataset.billing_export` #23

Closed brettcurtis closed 3 months ago

brettcurtis commented 3 months ago

Fixes #22

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes involve enhancing cloud cost management capabilities by introducing conditional logic for resource creation based on a specific variable, alongside adjustments in testing configurations and usage files. These modifications aim at optimizing cost management and addressing specific errors related to resource indexing in the infrastructure code.

Changes

File Path Change Summary
global/main.tf Added a conditional check to optionally create google_bigquery_dataset_iam_member resource.
test/fixtures/default_integration/infracost-usage.yml Removed usage values for google_bigquery_dataset and google_storage_bucket.
test/fixtures/default_integration/main.tf Modified enable_cloud_cost_management from true to false.

Assessment against linked issues

Objective Addressed Explanation
#22: Addressing the empty tuple error for google_bigquery_dataset.billing_export ✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
infracost[bot] commented 3 months ago

Infracost report

💰 Monthly cost will not change

Project Cost change New monthly cost
default_integration $0 $9
Cost details ``` ────────────────────────────────── Project: default_integration Module path: test/fixtures/default_integration - module.test.google_bigquery_dataset.billing_export[0] Monthly cost depends on usage - Queries (on-demand) Monthly cost depends on usage -$6.25 per TB - module.test.google_storage_bucket.cloud_cost_management[0] Monthly cost depends on usage - Storage (standard) Monthly cost depends on usage -$0.026 per GiB - Object adds, bucket/object list (class A) Monthly cost depends on usage -$0.05 per 10k operations - Object gets, retrieve bucket/object metadata (class B) Monthly cost depends on usage -$0.004 per 10k operations - Network egress - Data transfer in same continent Monthly cost depends on usage -$0.02 per GB - Data transfer to worldwide excluding Asia, Australia (first 1TB) Monthly cost depends on usage -$0.12 per GB - Data transfer to Asia excluding China, but including Hong Kong (first 1TB) Monthly cost depends on usage -$0.12 per GB - Data transfer to China excluding Hong Kong (first 1TB) Monthly cost depends on usage -$0.23 per GB - Data transfer to Australia (first 1TB) Monthly cost depends on usage -$0.19 per GB Monthly cost change for default_integration (Module path: test/fixtures/default_integration) Amount: $0.00 ($9 → $9) Percent: 0% ────────────────────────────────── Key: ~ changed, + added, - removed 11 cloud resources were detected: ∙ 3 were estimated, all of which include usage-based costs, see https://infracost.io/usage-file ∙ 8 were free ```

Governance checks

🟢 51 passed
50 FinOps policies and 1 Tagging policy passed.

View report in Infracost Cloud. This comment will be updated when code changes.