osinfra-io / terraform-datadog-google-integration

Terraform example module for Datadog Google Cloud Platform integration.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Deprecation of Kitchen-Terraform #35

Closed brettcurtis closed 6 months ago

brettcurtis commented 7 months ago

Fixes #29

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

[!WARNING]

Rate Limit Exceeded

@brettcurtis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 40 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between f93c5c6509122d0688c91ee78096adf807ba3dab and ff33706d9e0a705f2bbbd69f68a2f043940fa2ab.

Walkthrough

The updates primarily focus on transitioning from Kitchen-Terraform to Terraform's native test framework. Changes include renaming workflow jobs, updating repository sources, modifying service account and identity provider values, and introducing new test configurations and an empty Terraform file for initialization.

Changes

File Path Change Summary
.github/workflows/test.yml Job renamed, repository source updated, service_account and workload_identity_provider values changed
.pre-commit-config.yaml Updated repository revision
empty.tf, tests/... Added new files for Terraform initialization and testing
tests/fixtures/default/main.tf Updated source path in module "test" block

Assessment against linked issues

Objective Addressed Explanation
Tests re-written using native test framework [#29, #63, #20, #107, #17, #16, #36, #35, #18]
Address the deprecation of Kitchen-Terraform in the project [#95]
Identify and implement alternative solutions or replacements for Kitchen-Terraform [#95]
Update the project's codebase to remove dependencies on Kitchen-Terraform [#95]
Ensure that the project remains functional and stable after the removal of Kitchen-Terraform [#95]

Possibly related issues


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
infracost[bot] commented 7 months ago

💰 Infracost report

Monthly cost will not change

Changed project Baseline cost Usage cost* Total change New monthly cost
fixtures-default +$0 -$25 -$25 $0
tests-fixtures-default +$0 +$25 +$25 $25

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Cost details ``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: fixtures-default Module path: fixtures/default - module.test.google_logging_project_sink.integration -$5 - Logging data -$5, -10 GB* - module.test.google_pubsub_topic.integration -$5 - Message ingestion data -$5, -0.125 TiB* - module.test.google_pubsub_subscription.integration -$15 - Message delivery data -$5, -0.125 TiB* - Retained acknowledged message storage -$5, -18 GiB* - Snapshot message backlog storage -$5, -18 GiB* Monthly cost change for fixtures-default (Module path: fixtures/default) Amount: -$25 ($25 → $0.00) ────────────────────────────────── Project: tests-fixtures-default Module path: tests/fixtures/default + module.test.google_pubsub_subscription.integration +$15 + Message delivery data +$5, +0.125 TiB* + Retained acknowledged message storage +$5, +18 GiB* + Snapshot message backlog storage +$5, +18 GiB* + module.test.google_logging_project_sink.integration +$5 + Logging data +$5, +10 GB* + module.test.google_pubsub_topic.integration +$5 + Message ingestion data +$5, +0.125 TiB* Monthly cost change for tests-fixtures-default (Module path: tests/fixtures/default) Amount: +$25 ($0.00 → $25) ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed *Usage costs were estimated using Infracost Cloud settings, see docs for other options. 11 cloud resources were detected: ∙ 3 were estimated ∙ 8 were free ```

Governance checks

🟢 53 passed
52 FinOps policies and 1 Tagging policy passed.

View report in Infracost Cloud. This comment will be updated when code changes.