search

osinfra-io / terraform-datadog-google-integration

Terraform example module for Datadog Google Cloud Platform integration.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Terraform testing alignment #44

Closed brettcurtis closed 3 months ago

brettcurtis commented 3 months ago

Fixes #43

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates encompass enhancements in Terraform configurations and pre-commit settings aimed at improving clarity, configurability, and maintainability. Key changes include updates to resource comments, the introduction of local variables, and the implementation of input variables to reduce hardcoding. Additionally, the version increment of the checkov tool suggests a commitment to keeping security checks up-to-date. Overall, these modifications reflect a thoughtful approach to refining infrastructure management practices.

Changes

File(s) Change Summary
.pre-commit-config.yaml Updated checkov version from 3.2.217 to 3.2.219, likely including bug fixes and improvements.
main.tf, tests/default.tftest.hcl Added comments for clarity on resources, incorporated Checkov skip directives, and standardized mock resource naming with "mock-".
tests/fixtures/default/locals.tf Introduced a locals block defining a labels map for better label management and readability.
tests/fixtures/default/main.tf Replaced hardcoded values with variable references for enable_cloud_cost_management, labels, and project, enhancing configurability.
tests/fixtures/default/variables.tf Added input variables with type definitions for enable_cloud_cost_management, environment, and project, streamlining customization.
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
infracost[bot] commented 3 months ago

💰 Infracost report

This pull request is aligned with your company's FinOps policies and the Well-Architected Framework.

Monthly estimate increased by $20 📈
Changed project Baseline cost Usage cost* Total change New monthly cost
tests-fixtures-default +$0 +$20 +$20 (+81%) $45
*Usage costs were estimated using [Infracost Cloud settings](https://dashboard.infracost.io/org/osinfra-io/settings/usage-defaults), see [docs](https://www.infracost.io/docs/features/usage_based_resources/#infracost-usageyml) for other options.
Estimate details ``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: tests-fixtures-default Module path: tests/fixtures/default + module.test.google_storage_bucket.cloud_cost_management[0] +$15 + Storage (standard) +$5, +192 GiB* + Object adds, bucket/object list (class A) +$5, +100 10k operations* + Object gets, retrieve bucket/object metadata (class B) +$5, +1,250 10k operations* + Network egress + Data transfer to worldwide excluding Asia, Australia (first 1TB) Monthly cost depends on usage +$0.12 per GB + Data transfer to Asia excluding China, but including Hong Kong (first 1TB) Monthly cost depends on usage +$0.12 per GB + Data transfer to China excluding Hong Kong (first 1TB) Monthly cost depends on usage +$0.23 per GB + Data transfer to Australia (first 1TB) Monthly cost depends on usage +$0.19 per GB + module.test.google_bigquery_dataset.billing_export[0] +$5 + Queries (on-demand) +$5, +0.8 TB* Monthly cost change for tests-fixtures-default (Module path: tests/fixtures/default) Amount: +$20 ($25 → $45) Percent: +81% ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed *Usage costs were estimated using Infracost Cloud settings, see docs for other options. 15 cloud resources were detected: ∙ 5 were estimated ∙ 10 were free ```

This comment will be updated when code changes.