Support for GKE fleet management

brettcurtis commented 9 months ago

Fixes #18

Summary by CodeRabbit

New Features
- Updated google and kubernetes provider versions with new output value workload_identity_service_account_emails.
- Added shared backend configuration for GKE fleet members.
- Introduced resource usage estimates for Infracost calculations.
- Configured settings for GKE fleet members and introduced Terraform module.
Documentation
- Improved README files for better guidance on managing IAM and projects in Google Cloud.
- Added output values documentation for GKE fleet members.
Refactor
- Renamed and updated paths in configuration files for GKE fleet host and service structure.
- Streamlined project setup with variable name updates and removal of obsolete configurations.
Chores
- Updated configurations for more accurate cost estimation and testing.
- Introduced backend configurations for Terraform using Google Cloud Storage.

infracost[bot] commented 9 months ago

Infracost report

💰 Monthly cost will increase by $34 📈

Project	Module path	Cost change	New monthly cost
default_kubernetes_engine	test/fixtures/default_kubernetes_engine	-$113	$0
gke_fleet_host	test/fixtures/gke_fleet_host/regional	+$73	$73
gke_fleet_member	test/fixtures/gke_fleet_member/regional	+$73	$73

Cost details

``` ────────────────────────────────── Project: default_kubernetes_engine Module path: test/fixtures/default_kubernetes_engine - module.test_kubernetes_engine.google_container_cluster.this -$73 - Cluster management fee -$73 - module.test_kubernetes_engine.google_container_node_pool.this["standard-pool"] -$39 - Instance usage (Linux/UNIX, on-demand, g1-small) -$39 - Standard provisioned storage (pd-standard) $0.00 - module.test_kubernetes_engine.google_kms_crypto_key.cluster_database_encryption -$0.60 - Key versions -$0.60 - Operations -$0.00 Monthly cost change for default_kubernetes_engine (Module path: test/fixtures/default_kubernetes_engine) Amount: -$113 ($113 → $0.00) ────────────────────────────────── Project: gke_fleet_host Module path: test/fixtures/gke_fleet_host/regional + module.test_gke_fleet_host.google_container_cluster.this +$73 + Cluster management fee +$73 + module.test_gke_fleet_host.google_container_node_pool.this["standard-pool"] $0.00 + Instance usage (Linux/UNIX, on-demand, g1-small) $0.00 + Standard provisioned storage (pd-standard) $0.00 + module.test_gke_fleet_host.google_kms_crypto_key.cluster_database_encryption +$0.26 + Key versions +$0.26 + Operations Monthly cost depends on usage +$0.03 per 10k operations Monthly cost change for gke_fleet_host (Module path: test/fixtures/gke_fleet_host/regional) Amount: +$73 ($0.00 → $73) ────────────────────────────────── Project: gke_fleet_member Module path: test/fixtures/gke_fleet_member/regional + module.test_gke_fleet_service.google_container_cluster.this +$73 + Cluster management fee +$73 + module.test_gke_fleet_service.google_kms_crypto_key.cluster_database_encryption +$0.26 + Key versions +$0.26 + Operations Monthly cost depends on usage +$0.03 per 10k operations Monthly cost change for gke_fleet_member (Module path: test/fixtures/gke_fleet_member/regional) Amount: +$73 ($0.00 → $73) ────────────────────────────────── Key: ~ changed, + added, - removed 40 cloud resources were detected: ∙ 5 were estimated, all of which include usage-based costs, see https://infracost.io/usage-file ∙ 32 were free, rerun with --show-skipped to see details ∙ 3 are not supported yet, rerun with --show-skipped to see details Infracost estimate: Monthly cost will increase by $34 ↑ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓ ┃ Project ┃ Cost change ┃ New monthly cost ┃ ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━┫ ┃ default_kubernetes_engine ┃ -$113 ┃ $0.00 ┃ ┃ gke_fleet_host ┃ +$73 ┃ $73 ┃ ┃ gke_fleet_member ┃ +$73 ┃ $73 ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━━━━┛ ```

Governance checks

🟢 49 passed

48 FinOps policies and 1 Tagging policy passed.

_{View in Infracost Cloud. This comment will be updated when code changes.}

coderabbitai[bot] commented 9 months ago

Walkthrough

The updates focus on enhancing GKE fleet management capabilities, including fleet host project support, cluster registration, and configuration adjustments across various files. Changes span from Terraform configurations for IAM roles, GKE Hub integrations, to updated documentation and backend configurations, aiming to streamline GKE fleet management and deployment processes.

Changes

Files	Change Summary
`.yaml`, `.yml`	Updated configurations in YAML files for CodeRabbit, Infracost, and kitchen suite setups.
`README.md`, `global/README.md`, `global/onboarding/README.md`, `regional/README.md`, `regional/onboarding/README.md`	Added documentation and updated Google project services, provider versions, and configurations.
`global/.tf`, `regional/.tf`, `test/fixtures/gke_fleet_host//.tf`, `test/fixtures/gke_fleet_service//.tf`	Introduced and updated Terraform configurations for IAM roles, GKE Hub, project settings, and Kubernetes Engine settings.
`.md` (excluding READMEs), `.tf` excluding `*.md` and YAML files	Various updates including comment additions, renaming, and new configurations across Terraform and markdown documentation files.

Assessment against linked issues

Objective	Addressed	Explanation
Support for fleet host projects (#18)	✅
Support for registering clusters (#18)	✅

The changes align with the objectives for supporting GKE fleet management, including the setup for fleet host projects and the registration of clusters as outlined in the linked issue. The documentation updates and Terraform configurations reflect the necessary adjustments for these capabilities, indicating that the primary objectives have been addressed.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

osinfra-io / terraform-google-kubernetes-engine