In the context of PR #22, it was noted that the is hardcoded to 'test-gke-fleet-host-tf64-sb' within the module in . This limits the flexibility of the test configuration and could potentially affect the ability to test in different environments.
Suggestion:
Parameterize the to allow dynamic testing environments, enhancing the module's flexibility and usability.
Suggested change:
project_id = 'test-gke-fleet-host-tf64-sb'
project_id = var.project_id
This change would require adding a corresponding variable in the variables definition and ensuring it's passed correctly in test configurations.
In the context of PR #22, it was noted that the is hardcoded to 'test-gke-fleet-host-tf64-sb' within the module in . This limits the flexibility of the test configuration and could potentially affect the ability to test in different environments.
Suggestion: Parameterize the to allow dynamic testing environments, enhancing the module's flexibility and usability.
Suggested change:
This change would require adding a corresponding variable in the variables definition and ensuring it's passed correctly in test configurations.
Related PR: https://github.com/osinfra-io/terraform-google-kubernetes-engine/pull/22 Comment: https://github.com/osinfra-io/terraform-google-kubernetes-engine/pull/22#discussion_r1490282321