search

osinfra-io / terraform-google-kubernetes-engine

Terraform example module for Google Cloud Platform Kubernetes Engine cluster.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Improve tests #27

Closed brettcurtis closed 9 months ago

brettcurtis commented 9 months ago

Fixes #26

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

The suite of changes primarily focuses on enhancing the flexibility and maintainability of Terraform configurations for Google Kubernetes Engine (GKE) fleet management. It includes updates to provider versions, parameterization of project IDs for better modularity, and adjustments in resource naming and configurations. These modifications aim to improve the infrastructure as code (IaC) practices by making the codebase more dynamic, easier to manage, and aligned with best practices.

Changes

Files Summary
test/fixtures/gke_fleet_host/global/variables.tf, test/fixtures/gke_fleet_member/global/variables.tf Added a new variable declaration project_id of type string with default value.
test/fixtures/gke_fleet_host/global/variables.tf Swapped default values for region and project_id variables.
test/fixtures/gke_fleet_host/infracost-usage.yml, test/fixtures/gke_fleet_member/regional/infracost-usage.yml Renamed module references for GKE resources, removed usage definitions, affecting default values.
infracost.yml, infracost.yml.tmpl Reorganized project paths and names for GKE fleet hosts and members.

Assessment against linked issues

Objective Addressed Explanation
Parameterize project_id in test module for GKE fleet management tests (#26) ✅ The project_id has been parameterized in the test module for GKE fleet management tests as suggested in the linked issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
infracost[bot] commented 9 months ago

Infracost report

💰 Monthly cost will not change

Project Cost change New monthly cost
gke_fleet_host_regional $0 $113
gke_fleet_member_regional $0 $74
Cost details ``` ────────────────────────────────── Project: gke_fleet_host_regional Module path: test/fixtures/gke_fleet_host/regional + module.test.google_container_cluster.this +$73 + Cluster management fee +$73 + module.test.google_container_node_pool.this["standard-pool"] +$39 + Instance usage (Linux/UNIX, on-demand, g1-small) +$39 + Standard provisioned storage (pd-standard) $0.00 + module.test.google_kms_crypto_key.cluster_database_encryption +$0.60 + Key versions +$0.60 + Operations +$0.00 - module.test_gke_fleet_host.google_container_cluster.this -$73 - Cluster management fee -$73 - module.test_gke_fleet_host.google_container_node_pool.this["standard-pool"] -$39 - Instance usage (Linux/UNIX, on-demand, g1-small) -$39 - Standard provisioned storage (pd-standard) $0.00 - module.test_gke_fleet_host.google_kms_crypto_key.cluster_database_encryption -$0.60 - Key versions -$0.60 - Operations -$0.00 Monthly cost change for gke_fleet_host_regional (Module path: test/fixtures/gke_fleet_host/regional) Amount: $0.00 ($113 → $113) Percent: 0% ────────────────────────────────── Project: gke_fleet_member_regional Module path: test/fixtures/gke_fleet_member/regional + module.test.google_container_cluster.this +$73 + Cluster management fee +$73 + module.test.google_kms_crypto_key.cluster_database_encryption +$0.60 + Key versions +$0.60 + Operations +$0.00 - module.test_gke_fleet_service.google_container_cluster.this -$73 - Cluster management fee -$73 - module.test_gke_fleet_service.google_kms_crypto_key.cluster_database_encryption -$0.60 - Key versions -$0.60 - Operations -$0.00 Monthly cost change for gke_fleet_member_regional (Module path: test/fixtures/gke_fleet_member/regional) Amount: $0.00 ($74 → $74) Percent: 0% ────────────────────────────────── Project: gke_fleet_host_infracost-usage.yml Errors: could not detect path type for 'test/fixtures/gke_fleet_host/infracost-usage.yml' Try adding a config-file to configure how Infracost should run. See https://infracost.io/config-file for details and examples. ────────────────────────────────── Project: gke_fleet_member_infracost-usage.yml Errors: could not detect path type for 'test/fixtures/gke_fleet_member/infracost-usage.yml' Try adding a config-file to configure how Infracost should run. See https://infracost.io/config-file for details and examples. ────────────────────────────────── Key: ~ changed, + added, - removed 40 cloud resources were detected: ∙ 5 were estimated, all of which include usage-based costs, see https://infracost.io/usage-file ∙ 32 were free, rerun with --show-skipped to see details ∙ 3 are not supported yet, rerun with --show-skipped to see details ```

Governance checks

🟢 49 passed
48 FinOps policies and 1 Tagging policy passed.

View in Infracost Cloud. This comment will be updated when code changes.

brettcurtis commented 9 months ago

@coderabbitai review