Deprecation of Kitchen-Terraform

brettcurtis commented 5 months ago

Fixes #63

This PR just removes Kitchen-Terraform dependencies and does not cover re-writing in native terraform test

Summary by CodeRabbit

Documentation
- Removed outdated badges and references to tools in the main README.
- Updated example configurations and provider versions in regional documentation.
Chores
- Updated dependency configurations and pre-commit hooks.
- Adjusted .gitignore settings.
New Features
- Introduced a new test script for Zsh in the fixtures directory.
Refactor
- Modified source paths in various Terraform configuration files to correct module references.

infracost[bot] commented 5 months ago

💰 Infracost report

Monthly cost will decrease by $173 📉

Changed project	Baseline cost	Usage cost*	Total change	New monthly cost
fixtures-gke_fleet_host-regional_istio	+$7	+$0	+$7	$7
test-fixtures-gke_fleet_host-global	-$7	+$0	-$7	$0
test-fixtures-gke_fleet_host-regional	-$73	-$10	-$83	$0
test-fixtures-gke_fleet_host-regional_istio	-$7	+$0	-$7	$0
test-fixtures-gke_fleet_member-regional	-$73	-$10	-$83	$0

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Cost details

``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: fixtures-gke_fleet_host-regional_istio Module path: fixtures/gke_fleet_host/regional_istio + module.test.google_compute_global_address.istio_gateway[0] +$7 + IP address (unused) +$7 + module.test.google_dns_record_set.istio_gateway["gateway-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries + module.test.google_dns_record_set.istio_gateway["stream-team-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage + Queries Monthly cost depends on usage +$0.40 per 1M queries Monthly cost change for fixtures-gke_fleet_host-regional_istio (Module path: fixtures/gke_fleet_host/regional_istio) Amount: +$7 ($0.00 → $7) ────────────────────────────────── Project: test-fixtures-gke_fleet_host-global Module path: test/fixtures/gke_fleet_host/global - module.test.google_dns_record_set.istio_gateway_mci["gateway.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_dns_record_set.istio_gateway_mci["stream-team.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_compute_global_address.istio_gateway_mci[0] -$7 - IP address (unused) -$7 Monthly cost change for test-fixtures-gke_fleet_host-global (Module path: test/fixtures/gke_fleet_host/global) Amount: -$7 ($7 → $0.00) ────────────────────────────────── Project: test-fixtures-gke_fleet_host-regional Module path: test/fixtures/gke_fleet_host/regional - module.test.google_container_node_pool.this["standard-pool"] $0.00 - module.test.google_kms_crypto_key.cluster_database_encryption -$10 - Key versions -$5, -83 months* - Operations -$5, -166.6666 10k operations* - module.test.google_container_cluster.this -$73 - Cluster management fee -$73 Monthly cost change for test-fixtures-gke_fleet_host-regional (Module path: test/fixtures/gke_fleet_host/regional) Amount: -$83 ($83 → $0.00) ────────────────────────────────── Project: test-fixtures-gke_fleet_host-regional_istio Module path: test/fixtures/gke_fleet_host/regional_istio - module.test.google_dns_record_set.istio_gateway["gateway-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_dns_record_set.istio_gateway["stream-team-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_compute_global_address.istio_gateway[0] -$7 - IP address (unused) -$7 Monthly cost change for test-fixtures-gke_fleet_host-regional_istio (Module path: test/fixtures/gke_fleet_host/regional_istio) Amount: -$7 ($7 → $0.00) ────────────────────────────────── Project: test-fixtures-gke_fleet_member-regional Module path: test/fixtures/gke_fleet_member/regional - module.test.google_kms_crypto_key.cluster_database_encryption -$10 - Key versions -$5, -83 months* - Operations -$5, -166.6666 10k operations* - module.test.google_container_cluster.this -$73 - Cluster management fee -$73 Monthly cost change for test-fixtures-gke_fleet_member-regional (Module path: test/fixtures/gke_fleet_member/regional) Amount: -$83 ($83 → $0.00) ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed 10 projects have no cost estimate changes. Run the following command to see their breakdown: infracost breakdown --path=/path/to/code ────────────────────────────────── *Usage costs were estimated using Infracost Cloud settings, see docs for other options. 3 cloud resources were detected: ∙ 3 were estimated Infracost estimate: Monthly cost will decrease by $173 ↓ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Changed project ┃ Baseline cost ┃ Usage cost ┃ Total change ┃ ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫ ┃ fixtures-gke_fleet_host-regional_istio ┃ +$7 ┃ +$0 ┃ +$7 ┃ ┃ test-fixtures-gke_fleet_host-global ┃ -$7 ┃ +$0 ┃ -$7 ┃ ┃ test-fixtures-gke_fleet_host-regional ┃ -$73 ┃ -$10 ┃ -$83 ┃ ┃ test-fixtures-gke_fleet_host-regional_istio ┃ -$7 ┃ +$0 ┃ -$7 ┃ ┃ test-fixtures-gke_fleet_member-regional ┃ -$73 ┃ -$10 ┃ -$83 ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛ ```

Governance checks

🟢 53 passed

52 FinOps policies and 1 Tagging policy passed.

_{View report in Infracost Cloud. This comment will be updated when code changes.}

coderabbitai[bot] commented 5 months ago

Walkthrough

This set of changes primarily focuses on the deprecation of Kitchen-Terraform, updating dependencies, and modifying paths in Terraform configurations. It involves removing outdated testing frameworks and badges, updating the .pre-commit-config.yaml with newer versions, and adjusting source paths in multiple Terraform files to reflect new directory structures.

Changes

File Pattern	Change Summary
`.github/dependabot.yml`, `.gitignore`, `README.md`	Removed configurations and references related to outdated tools and dependencies.
`.pre-commit-config.yaml`	Updated hook versions and modified path exclusions.
`fixtures/gke_fleet_/*/main.tf`	Updated module source paths to new relative locations.
`regional/README.md`, `regional/istio/README.md`	Downgraded provider versions.
`fixtures/test.zsh`	Added new Zsh script file.

Assessment against linked issues

Objective	Addressed	Explanation
Deprecation of Kitchen-Terraform and transition to native test framework [63, 95, 20, 107, 36, 16, 17, 35, 29, 18]	❌	The PR lacks changes indicating the implementation of the new native test framework.

Possibly related issues

Issue #95: The removal of Kitchen-Terraform references in the README.md aligns with the objectives to remove dependencies on Kitchen-Terraform.
Issue #20, #107, #36, #16, #17, #35, #29, #18: Each of these issues revolves around the deprecation of Kitchen-Terraform and transitioning to a new testing framework, which is partially addressed by removing outdated references, though the implementation of the new framework is not evident.

Recent Review Details

**Configuration used: CodeRabbit UI**

Commits

Files that changed from the base of the PR and between 263c7336a738413000a3710bcdc90588a2e6af9a and 95a4d1866055d40daa3bea0913a7aadbd2eaaa37.

Files ignored due to path filters (1)

* `Gemfile.lock` is excluded by `!**/*.lock`

Files selected for processing (16)

* .github/dependabot.yml (1 hunks) * .gitignore (1 hunks) * .pre-commit-config.yaml (2 hunks) * README.md (4 hunks) * fixtures/gke_fleet_host/global/main.tf (1 hunks) * fixtures/gke_fleet_host/regional/main.tf (1 hunks) * fixtures/gke_fleet_host/regional_istio/main.tf (1 hunks) * fixtures/gke_fleet_host/regional_mci/main.tf (1 hunks) * fixtures/gke_fleet_host/regional_onboarding/main.tf (1 hunks) * fixtures/gke_fleet_member/global/main.tf (1 hunks) * fixtures/gke_fleet_member/regional/main.tf (1 hunks) * fixtures/gke_fleet_member/regional_istio/main.tf (1 hunks) * fixtures/gke_fleet_member/regional_onboarding/main.tf (1 hunks) * fixtures/test.zsh (1 hunks) * regional/README.md (1 hunks) * regional/istio/README.md (1 hunks)

Files skipped from review due to trivial changes (9)

* .pre-commit-config.yaml * fixtures/gke_fleet_host/global/main.tf * fixtures/gke_fleet_host/regional/main.tf * fixtures/gke_fleet_host/regional_mci/main.tf * fixtures/gke_fleet_host/regional_onboarding/main.tf * fixtures/gke_fleet_member/global/main.tf * fixtures/gke_fleet_member/regional/main.tf * fixtures/gke_fleet_member/regional_istio/main.tf * fixtures/test.zsh

Additional Context Used

LanguageTool (173)

README.md (19)

Near line 1: Possible spelling mistake found. Context: # Open Source Infrastructure (as Code) is a developme... --- Near line 42: If this is a compound adjective that modifies the following noun, use a hyphen. Context: ...zations can use internally at scale. - [Open Source Infrastructure (as Code)](https://www.o... --- Near line 44: If this is a compound adjective that modifies the following noun, use a hyphen. Context: ... the possibility for contributions. The Open Source Infrastructure (as Code) model allows t... --- Near line 44: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. Context: ...oad. This section is for developers who want to contribute to this repository, describi... --- Near line 51: Possible spelling mistake found. Context: ...🛠️ Tools - [helm](https://helm.sh) - [infracost](https://github.com/infracost/infracost... --- Near line 60: This sentence does not start with an uppercase letter. Context: ...te in this repository successfully. - [istio](https://istio.io/latest/docs) - [ist... --- Near line 61: Possible spelling mistake found. Context: ...tio](https://istio.io/latest/docs) - [istio on gke](https://istio.io/latest/docs/se... --- Near line 61: Possible spelling mistake found. Context: ...s://istio.io/latest/docs) - [istio on gke](https://istio.io/latest/docs/setup/pla... --- Near line 62: Possible spelling mistake found. Context: ...atest/docs/setup/platform-setup/gke) - [kubernetes engine](https://cloud.google.com/kubern... --- Near line 65: Possible spelling mistake found. Context: ...s-engine/docs/concepts/node-pools) - [RBAC](https://cloud.google.com/kubernetes-en... --- Near line 67: Possible spelling mistake found. Context: ...ocs/how-to/workload-identity) - [shared vpc](https://cloud.google.com/vpc/docs/shar... --- Near line 72: You might be missing the article “the” here. Context: ...the tests. This group manages access to Testing/Sandbox folder in the resource hierarch... --- Near line 81: Possible typo: you repeated a word Context: ...tation - [global](global/README.md) - [regional](regional/README.md) - [regional/istio](regional/istio/README.md) - [reg... --- Near line 82: Possible spelling mistake found. Context: ...gional](regional/README.md) - [regional/istio](regional/istio/README.md) - [regional/... --- Near line 83: Possible spelling mistake found. Context: ...](regional/istio/README.md) - [regional/mci](regional/mci/README.md) - [regional/on...

regional/README.md (115)

Near line 3: Possible spelling mistake found. Context: ...atically inherits its parent's default (un-aliased) provider configurations. The provider ... --- Near line 28: Possible spelling mistake found. Context: ...ainer_node_pool) | resource | | [google_gke_hub_feature.multi_cluster_ingress](http... --- Near line 29: Possible spelling mistake found. Context: ...gke_hub_feature) | resource | | [google_gke_hub_feature.multi_cluster_service_disco... --- Near line 30: Possible spelling mistake found. Context: ...gke_hub_feature) | resource | | [google_gke_hub_membership.clusters](https://regist... --- Near line 31: Possible spelling mistake found. Context: ..._hub_membership) | resource | | [google_gke_hub_membership.host](https://registry.t... --- Near line 32: Possible spelling mistake found. Context: ..._hub_membership) | resource | | [google_kms_crypto_key.cluster_database_encryption]... --- Near line 33: Possible spelling mistake found. Context: .../kms_crypto_key) | resource | | [google_kms_crypto_key_iam_member.cluster_database_... --- Near line 33: Possible spelling mistake found. Context: ...) | resource | | [google_kms_crypto_key_iam_member.cluster_database_encryption](htt... --- Near line 34: Possible spelling mistake found. Context: ..._key_iam_member) | resource | | [google_kms_key_ring.cluster_database_encryption](h... --- Near line 35: Possible spelling mistake found. Context: ...ey_ring) | resource | | [google_project_iam_member.gke_operations](https://registry... --- Near line 45: Possible spelling mistake found. Context: ... of node auto-provisioning with cluster autoscaler to automatically adjust the size of the... --- Near line 45: Possible typo: you repeated a whitespace Context: ...e cluster's workload |

object({
    autoscaling_profile                     ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...object({
    autoscaling_profile                      = optional(string, "OPTIMIZE_UTILIZATION...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...onal(string, "OPTIMIZE_UTILIZATION")
    disk_type                               ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ..."OPTIMIZE_UTILIZATION")
    disk_type                                = optional(string)
    enabled       ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    enabled                                 ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...       = optional(string)
    enabled                                  = optional(bool, false)
    image_typ...

---

Near line 45: Possible spelling mistake found.
Context: ...                             = optional(bool, false)
    image_type              ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...             = optional(bool, false)
    image_type                              ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ... optional(bool, false)
    image_type                               = optional(string)
    oauth_scopes  ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    oauth_scopes                            ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...  = optional(string)
    oauth_scopes                             = optional(list(string), ["https://www.g...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...oogleapis.com/auth/cloud-platform"])
    resource_limits_min_cpu_cores           ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ..."])
    resource_limits_min_cpu_cores            = optional(number, 0)
    resource_li...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...res            = optional(number, 0)
    resource_limits_min_memory_gb           ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ... 0)
    resource_limits_min_memory_gb            = optional(number, 0)
    resource_li...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ..._gb            = optional(number, 0)
    resource_limits_max_cpu_cores           ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ... 0)
    resource_limits_max_cpu_cores            = optional(number, 6)
    resource_li...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...res            = optional(number, 6)
    resource_limits_max_memory_gb           ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ... 6)
    resource_limits_max_memory_gb            = optional(number, 32)
    upgrade_se...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...gb            = optional(number, 32)
    upgrade_settings_batch_node_count       ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...br>    upgrade_settings_batch_node_count        = optional(number)
    upgrade_settin...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...node_count        = optional(number)
    upgrade_settings_batch_percentage       ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...br>    upgrade_settings_batch_percentage        = optional(number)
    upgrade_settin...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...percentage        = optional(number)
    upgrade_settings_batch_soak_duration    ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...    upgrade_settings_batch_soak_duration     = optional(string)
    upgrade_settin...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...soak_duration     = optional(string)
    upgrade_settings_node_pool_soak_duration...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...ool_soak_duration = optional(string)
    upgrade_settings_max_surge              ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...tring)
    upgrade_settings_max_surge               = optional(number)
    upgrade_settin...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...rge               = optional(number)
    upgrade_settings_max_unavailable        ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...
    upgrade_settings_max_unavailable         = optional(number, 1) # https://github.c...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...rraform-provider-google/issues/17164
    upgrade_settings_strategy               ...

---

Near line 45: Possible typo: you repeated a whitespace
Context: ...s/17164
    upgrade_settings_strategy                = optional(string, "SURGE")
  })  })
 | `{}` | no | |  [enable\_gke\_hub\_host]...

---

Near line 49: Possible spelling mistake found.
Context: ...nput_enable_gke_hub_host"> [enable\_gke\_hub\_host](#input\_enable\_gke\_hub\_h...

---

Near line 49: Possible spelling mistake found.
Context: ...e_hub_host"> [enable\_gke\_hub\_host](#input\_enable\_gke\_hub\_host) | Whether or not to enable ...

---

Near line 49: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’.
Context: ...host](#input\_enable\_gke\_hub\_host) | Whether or not to enable GKE Hub Host | `bool` | `fals...

---

Near line 49: Possible spelling mistake found.
Context: ...Whether or not to enable GKE Hub Host | `bool` | `false` | no | |  [gke\_hub\_member...

---

Near line 50: Possible spelling mistake found.
Context: ... name="input_gke_hub_memberships"> [gke\_hub\_memberships](#input\_gke\_hub\_me...

---

Near line 50: Possible spelling mistake found.
Context: ...memberships"> [gke\_hub\_memberships](#input\_gke\_hub\_memberships) | The map of GKE Hub...

---

Near line 50: Possible typo: you repeated a whitespace
Context: ...rships to create | map(object({
    cluster_id = string
  })) | `{}...

---

Near line 50: Don’t put a space before the closing parenthesis.
Context: ...object({
    cluster_id = string
  }))

| `{}` | no | | [kuberne... --- Near line 51: Possible spelling mistake found. Context: ...ernetes_daily_maintenance_window"> [kubernetes\_daily\_maintenance\_window](#input\_ku... --- Near line 51: Possible spelling mistake found. Context: ... [kubernetes\_daily\_maintenance\_window](#input\_kubernetes\_daily\_maintenance\_window) | Time win... --- Near line 52: It appears that a white space is missing. Context: ...assign to the resources being created | `map(string)` | `{}` | no | | [master\_ipv4\_cidr\_block]... --- Near line 53: Possible spelling mistake found. Context: ...er_ipv4_cidr_block"> [master\_ipv4\_cidr\_block](#input\_master\_ipv4\_cidr\_blo... --- Near line 53: Possible spelling mistake found. Context: ...r_block"> [master\_ipv4\_cidr\_block](#input\_master\_ipv4\_cidr\_block) | The IP range in CIDR notation... --- Near line 56: Possible typo: you repeated a whitespace Context: ...ining node pools |

map(object({
    auto_repair                             ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...s | map(object({
    auto_repair                              = optional(bool)
    auto_upgrade    ...

---

Near line 56: Possible spelling mistake found.
Context: ...                             = optional(bool)
    auto_upgrade                   ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                    = optional(bool)
    auto_upgrade                            ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...    = optional(bool)
    auto_upgrade                             = optional(bool)
    disk_size_gb    ...

---

Near line 56: Possible spelling mistake found.
Context: ...                             = optional(bool)
    disk_size_gb                   ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                    = optional(bool)
    disk_size_gb                            ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...    = optional(bool)
    disk_size_gb                             = optional(number)
    disk_type     ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(number)
    disk_type                               ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...     = optional(number)
    disk_type                                = optional(string)
    image_type    ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    image_type                              ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...    = optional(string)
    image_type                               = optional(string)
    machine_type  ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    machine_type                            ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...  = optional(string)
    machine_type                             = optional(string)
    max_node_count...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    max_node_count                          ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...= optional(string)
    max_node_count                           = optional(number, 3)
    min_node_co...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...               = optional(number, 3)
    min_node_count                          ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...ptional(number, 3)
    min_node_count                           = optional(number, 0)
    node_count ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...               = optional(number, 0)
    node_count                              ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ... = optional(number, 0)
    node_count                               = optional(number)
    oauth_scopes  ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(number)
    oauth_scopes                            ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...  = optional(number)
    oauth_scopes                             = optional(list(string), ["https://www.g...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...oogleapis.com/auth/cloud-platform"])
    service_account                         ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...cloud-platform"])
    service_account                          = optional(string)
    upgrade_settin...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...                  = optional(string)
    upgrade_settings_batch_node_count       ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...br>    upgrade_settings_batch_node_count        = optional(number)
    upgrade_settin...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...node_count        = optional(number)
    upgrade_settings_batch_percentage       ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...br>    upgrade_settings_batch_percentage        = optional(number)
    upgrade_settin...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...percentage        = optional(number)
    upgrade_settings_batch_soak_duration    ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...    upgrade_settings_batch_soak_duration     = optional(string)
    upgrade_settin...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...soak_duration     = optional(string)
    upgrade_settings_node_pool_soak_duration...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...ool_soak_duration = optional(string)
    upgrade_settings_max_surge              ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...tring)
    upgrade_settings_max_surge               = optional(number)
    upgrade_settin...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...rge               = optional(number)
    upgrade_settings_max_unavailable        ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...
    upgrade_settings_max_unavailable         = optional(number, 1) # https://github.c...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...rraform-provider-google/issues/17164
    upgrade_settings_strategy               ...

---

Near line 56: Possible typo: you repeated a whitespace
Context: ...s/17164
    upgrade_settings_strategy                = optional(string, "SURGE")
  }))  }))
 | `{}` | no | |  [vpc\_host\_proje...

---

Near line 63: Possible spelling mistake found.
Context: ... name="input_vpc_host_project_id"> [vpc\_host\_project\_id](#input\_vpc\_host\_...

---

Near line 63: Possible spelling mistake found.
Context: ...project_id"> [vpc\_host\_project\_id](#input\_vpc\_host\_project\_id) | Host project for ...

---

Near line 73: Possible spelling mistake found.
Context: ...que within the project and location | |  [kms\_crypto\_key\_cluster\_database\_encryp...

---

Near line 73: Possible spelling mistake found.
Context: ...key\_cluster\_database\_encryption\_name](#output\_kms\_crypto\_key\_cluster\_database\_encryp...

---

Near line 74: Possible spelling mistake found.
Context: ...pto key used to encrypt the secrets | |  [kms\_key\_ring\_cluster\_database\_encrypti...

---

Near line 74: Possible spelling mistake found.
Context: ...ing\_cluster\_database\_encryption\_name](#output\_kms\_key\_ring\_cluster\_database\_encrypti...

---

Near line 76: Possible spelling mistake found.
Context: ...oject in which the resource belongs | |  [service\_accoun...

---

Near line 76: Possible spelling mistake found.
Context: ...erations_email"> [service\_account\_gke\_operations\_email](#output\_service\_a...

---

Near line 76: Possible spelling mistake found.
Context: ...service\_account\_gke\_operations\_email](#output\_service\_account\_gke\_operations\_email) | The email address...

regional/istio/README.md (39)

Near line 3: Possible spelling mistake found. Context: ... module automatically inherits default (un-aliased) provider configurations from its paren... --- Near line 16: Possible spelling mistake found. Context: ...a> [helm](#provider\_helm) | 2.12.1 | | [kubernetes](#provider\_kubernete... --- Near line 16: Possible spelling mistake found. Context: ...| | [kubernetes](#provider\_kubernetes) | 2.26.0 | ## ... --- Near line 27: Possible spelling mistake found. Context: ..._global_address) | resource | | [google_dns_record_set.istio_gateway](https://regis... --- Near line 31: Possible spelling mistake found. Context: ...docs/resources/release) | resource | | [kubernetes_ingress_v1.istio_gateway](https://regis... --- Near line 32: Possible spelling mistake found. Context: ...s/resources/ingress_v1) | resource | | [kubernetes_manifest.istio_gateway_backendconfig](h... --- Near line 32: Possible spelling mistake found. Context: ...v1) | resource | | [kubernetes_manifest.istio_gateway_backendconfig](https://registry... --- Near line 33: Possible spelling mistake found. Context: ...ocs/resources/manifest) | resource | | [kubernetes_manifest.istio_gateway_frontendconfig](... --- Near line 33: Possible spelling mistake found. Context: ...st) | resource | | [kubernetes_manifest.istio_gateway_frontendconfig](https://registr... --- Near line 34: Possible spelling mistake found. Context: ...ocs/resources/manifest) | resource | | [kubernetes_manifest.istio_gateway_managed_certific... --- Near line 34: Possible spelling mistake found. Context: ...st) | resource | | [kubernetes_manifest.istio_gateway_managed_certificate](https://re... --- Near line 42: Possible spelling mistake found. Context: ...cluster name | `string` | n/a | yes | | [enable\_istio\_gateway](... --- Near line 42: Possible spelling mistake found. Context: ...put_enable_istio_gateway"> [enable\_istio\_gateway](#input\_enable\_istio\_gatewa... --- Near line 42: Possible spelling mistake found. Context: ...io_gateway"> [enable\_istio\_gateway](#input\_enable\_istio\_gateway) | Enable the Istio gateway, u... --- Near line 42: Possible spelling mistake found. Context: ...t\_enable\_istio\_gateway) | Enable the Istio gateway, used for ingress traffic into ... --- Near line 42: Possible spelling mistake found. Context: ...sed for ingress traffic into the mesh | `bool` | `false` | no | | [istio\_chart\_r... --- Near line 45: Possible spelling mistake found. Context: ...me="input_istio_chart_repository"> [istio\_chart\_repository](#input\_istio\_char... --- Near line 45: Possible spelling mistake found. Context: ...pository"> [istio\_chart\_repository](#input\_istio\_chart\_repository) | The repository to... --- Near line 45: Possible spelling mistake found. Context: ...epository) | The repository to pull the Istio Helm chart from | `string` | `"https://... --- Near line 46: Possible spelling mistake found. Context: ...torage.googleapis.com/charts"` | no | | [istio\_gateway\_dns]... --- Near line 46: Possible spelling mistake found. Context: ... [istio\_gateway\_dns](#input\_istio\_gateway\_... --- Near line 46: Possible spelling mistake found. Context: ...stio_gateway_dns"> [istio\_gateway\_dns](#input\_istio\_gateway\_dns) | Map of ... --- Near line 46: Possible spelling mistake found. Context: ...teway\_dns) | Map of attributes for the Istio gateway domain names, it is also used t... --- Near line 46: Possible typo: you repeated a whitespace Context: ...ificate resource |
map(object({
    managed_zone = string
    project    ...

---

Near line 46: Possible typo: you repeated a whitespace
Context: ...bject({
    managed_zone = string
    project      = string
  }))
| `... --- Near line 46: Possible typo: you repeated a whitespace Context: ... managed_zone = string
project = string
})) | `{}` | no | | ... --- Near line 46: Don’t put a space before the closing parenthesis. Context: ...string
project = string
})) | `{}` | no | | [istio\_version](#input\_... --- Near line 47: Possible spelling mistake found. Context: ...| | [istio\_version](#input\_istio\_version) | The... --- Near line 47: Possible spelling mistake found. Context: ...nput_istio_version"> [istio\_version](#input\_istio\_version) | The version of istio to ins... --- Near line 47: Possible spelling mistake found. Context: ...input\_istio\_version) | The version of istio to install | `string` | `"1.20.3"` | no... --- Near line 56: Possible spelling mistake found. Context: ... Description | |------|-------------| | [istio\_gateway\_ip](#... --- Near line 56: Possible spelling mistake found. Context: ... [istio\_gateway\_ip](#output\_istio\_gateway\_... --- Near line 56: Possible spelling mistake found. Context: ...istio_gateway_ip"> [istio\_gateway\_ip](#output\_istio\_gateway\_ip) | The IP ... --- Near line 56: Possible spelling mistake found. Context: ...o\_gateway\_ip) | The IP address of the Istio Gateway | The 'fixtures' directory is correctly referenced and accessible in the repository as indicated in the README.md file. -

Scripts Executed

The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Check if the updated path in the fixtures directory is correct and accessible. fd --type d 'fixtures' . ``` Length of output: 36

regional/README.md (1)

`14-15`: Provider versions downgraded to 5.16.0. The downgrade of the `google` and `google-beta` providers to version 5.16.0 is consistent with the PR's objective to adjust provider versions. Ensure that this version is compatible with all used resources and features in your Terraform configurations.

---

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

osinfra-io / terraform-google-kubernetes-engine