osinfra-io / terraform-google-kubernetes-engine

Terraform example module for Google Cloud Platform Kubernetes Engine cluster.
https://www.osinfra.io
GNU General Public License v2.0
1 stars 0 forks source link

Remove Istio #80

Closed brettcurtis closed 4 months ago

brettcurtis commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent changes involve removing references to Istio, particularly its configurations and resources, from multiple files. The updates also include renaming certain test blocks and adding the tool checkov to the README file. The Google provider version has been bumped from 5.36.0 to 5.37.0, reflecting a minor update.

Changes

File/Directory Change Summary
README.md Added checkov tool, removed Istio references, updated Google provider version to 5.37.0.
tests/default.tftest.hcl Removed mock_provider "helm", renamed test runs, removed Istio-related test runs.
tests/fixtures/gke_fleet_host/regional_mci/main.tf Removed istio_gateway_mci_global_address from module "test".
locals.tf Removed istio_gateway_domains declaration from locals block.
main.tf Removed resources related to Google Compute and DNS management for Istio Gateway.
outputs.tf Removed Istio Gateway multi-cluster ingress SSL certificate and address outputs.
tests/fixtures/gke_fleet_host/main.tf Removed istio_gateway_dns block.
tests/fixtures/gke_fleet_host/outputs.tf Removed output declarations for istio_gateway_mci_global_address and istio_gateway_mci_ssl_certificate_name.
tests/fixtures/gke_fleet_host/variables.tf Removed dns_project_id and istio_gateway_domain variable declarations.
variables.tf Removed istio_gateway_dns variable declaration.

Sequence Diagram(s)

No sequence diagrams necessary as changes are primarily configuration and resource removals without altering control flow.


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
infracost[bot] commented 4 months ago

💰 Infracost report

This pull request is aligned with your company's FinOps policies and the Well-Architected Framework.

Monthly estimate decreased by $7 📉
Changed project Baseline cost Usage cost* Total change New monthly cost
tests-fixtures-gke_fleet_host-regional_istio -$7 +$0 -$7 $0
*Usage costs were estimated using [Infracost Cloud settings](https://dashboard.infracost.io/org/osinfra-io/settings/usage-defaults), see [docs](https://www.infracost.io/docs/features/usage_based_resources/#infracost-usageyml) for other options.
Estimate details ``` Key: * usage cost, ~ changed, + added, - removed ────────────────────────────────── Project: tests-fixtures-gke_fleet_host-regional_istio Module path: tests/fixtures/gke_fleet_host/regional_istio - module.test.google_dns_record_set.istio_gateway["gateway-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_dns_record_set.istio_gateway["stream-team-us-east1-b.test.gcp.osinfra.io"] Monthly cost depends on usage - Queries Monthly cost depends on usage -$0.40 per 1M queries - module.test.google_compute_global_address.istio_gateway[0] -$7 - IP address (unused) -$7 Monthly cost change for tests-fixtures-gke_fleet_host-regional_istio (Module path: tests/fixtures/gke_fleet_host/regional_istio) Amount: -$7 ($7 → $0) ────────────────────────────────── Key: * usage cost, ~ changed, + added, - removed 2 projects have no cost estimate changes. Run the following command to see their breakdown: infracost breakdown --path=/path/to/code ────────────────────────────────── *Usage costs were estimated using Infracost Cloud settings, see docs for other options. No cloud resources were detected ```

This comment will be updated when code changes.