Open gndrmnn opened 1 year ago
Thanks for moving this "commented suggestions" to a whole issue. If you approach implementing this for Glance, be sure to first write a spec for this feature and discuss with the core devs how this should work.
I am tracking this issue here, but please do keep me in the loop if you start working on this for Glance.
But with the Victoria release the former single MD5 hash was deprecated: https://docs.openstack.org/releasenotes/glance/victoria.html#deprecation-notes in favor of "multihash". While this sounds cool, multihash is only about being able to configure(!) a single hash algo that is then used: https://github.com/openstack/glance/blob/b023562e1d31d3e60c195d701e6a9ff52e2fc956/doc/source/admin/os_hash_algo.rst#secure-hash-algorithm-support-multihash, or https://docs.openstack.org/glance/latest/configuration/sample-configuration.html:
The default of SHA-512 is not provided by most image upstreams though. SHA-256 is very common, but for upstreams not providing the chosen hash algo, no checkum verification can be done. Would be nice to be able to provide any hash value of supported algos with the webdownload via image_url ... but that's an upstream change and will even if implemented take a while until is reaches most OpenStack installations.
Originally posted by @frittentheke in https://github.com/osism/openstack-image-manager/issues/340#issuecomment-1471721379