Avoid deleting attached FIPs, better port filtering.

[garloff]

Avoid deleting attached FIPs, better port filtering.

The filter in the search_floating_ip() statement does not do what it is supposed to. Instead skip if there is a fixed_ip_address.

For port cleanup, provide better logic:

• Delete port unconditionally if it's name matches the prefix
• Keep it unconditionally if it has a name that does not match
• IF we have a list of IPADDR strings the beginning of the ip addresses will be matched against the IPADDR strings; delete if there is a match, do not delete if there is no match. Always match, if no IPADDR filter is passed.

The filtering can be used to ensure we only delete IP addresses from IP ranges in subnets that we have created. This improves coexistence with other infrastructure in the smae project. (If you can, avoid coexistence, though.)

This is a port from https://github.com/SovereignCloudStack/standards/pull/712

This should fix https://github.com/osism/issues/issues/960

[garloff]

Note that while I have tested the version in the standards repo extensively, this one has only seen light testing. Currently we also don't use the IPADDR="ippref1,ippref2,..." filter yet when calling the script -- something that we might want to add. If we don't, we still have better protection for

• ports that have a name without matching the PREFIX
• floating IPs that are attached