osixia / container-baseimage

A container base image to build reliable single or multiprocess images quickly 🐳✨🌴
MIT License
132 stars 115 forks source link

allow usage of additional hostnames in self signed certificate #19

Closed Bobonium closed 4 years ago

Bobonium commented 4 years ago

controlled by env var ADDITIONAL_HOSTNAMES should be comma separated list as per cfssl documentation

My use case is relatively simple explained. I'm using your openldap image in kubernetes and I'd like to be able have replication between masters encrypted as well as encrypted traffic through the service load balancing.

For this to work I need to be able to setup additional Hostnames for the generated certificates. I'm already using this change by simply injecting the modified script through a configmap without any problems.

BertrandGouny commented 4 years ago

merged in v1.2.0 Thanks ! :)