search

oskarnie14 / lidgren-network-gen3

Automatically exported from code.google.com/p/lidgren-network-gen3
0 stars 0 forks source link

Forgotten constants #139

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In NetFragmentationHelper.GetBestChunkSize()

The line has 2 numbers that isn't clear what they are there for, 5 which i 
guess is Netconstants.HeaderByteSize and the one could be removed and >= 
changed to >.

while (tryChunkSize + headerSize + 5 + 1 >= mtu);

If you change the header down the line this could become an issue

Original issue reported on code.google.com by Rsamuels...@gmail.com on 24 Oct 2012 at 12:11

GoogleCodeExporter commented 9 years ago 
Type should be enchancement but i couldn't find how to change it :/

Original comment by Rsamuels...@gmail.com on 24 Oct 2012 at 12:14

GoogleCodeExporter commented 9 years ago 
Thanks, good idea! Fixed in revision 319

Original comment by lidg...@gmail.com on 24 Oct 2012 at 1:07