oskarrough / ember-wordpress

The bridge between Ember.js and Wordpress
http://ember-wordpress.surge.sh
MIT License
95 stars 26 forks source link

Use ember-fetch in place of ember-ajax #35

Closed nanaewusi closed 7 years ago

MartinMalinda commented 7 years ago

As far as I know this will have no effect. Ember data has own logic for making ajax requests and ember-ajax is a devDependency and therefore will have no impact on the parent application.

oskarrough commented 7 years ago

Thank you @nanaewusi.

@MartinMalinda ah really. In that case can we just remove ember-ajax? I see there's still some discussion as to what to use for Ember Data. https://github.com/emberjs/data/issues/4929

MartinMalinda commented 7 years ago

@oskarrough We can remove it, but because it is a devDepedency it will have no effect on the parent application.

nanaewusi commented 7 years ago

@MartinMalinda Oh. Thanks for the clarification.