search

oskca / gopherjs-vue

VueJS bindings for gopherjs
MIT License
149 stars 17 forks source link

Allow use of non-minified vue.js to allow debugging #6

Open johanbrandhorst opened 7 years ago

johanbrandhorst commented 7 years ago

The vue devtools requires the vue.js file to be in "non-production" mode. Currently the version used is minified, which makes it impossible to use the debugging tools, which is a shame.

oskca commented 7 years ago

Maybe I shall not include the VueJS in the GopherJS package directly?

johanbrandhorst commented 7 years ago

That would be another alternative

oskca commented 7 years ago

It's done by https://github.com/oskca/gopherjs-vue/commit/2ff578cf2f64413d11086782e0476768d55bd077 @johanbrandhorst

johanbrandhorst commented 7 years ago

Thanks! I think you should probably add it to your README as well so users aren't confused why their code doesn't work. This means another setup step is to download a suitable version of vue.js and name it the correct thing and put it in the right place, so it should be in the README.

oskca commented 7 years ago

as in https://github.com/oskca/gopherjs-vue/commit/ab40c9e57345d35375c820c8e885d28ed70f165e, you can now use building tags to switch the VueJS versions. :smile:

johanbrandhorst commented 7 years ago

Nice work!

johanbrandhorst commented 7 years ago

Actually I have to reopen this as no matter how I try I can't seem to get it compiled with the minified version?

oskca commented 7 years ago

When switching the building tags the building procedures works as expected, but the outcomes always include only one version of the *.inc.js code. I think this's a bug of gopherjs building tools, and filed an issue report: https://github.com/gopherjs/gopherjs/issues/598.

johanbrandhorst commented 7 years ago

Ah, good digging!