search

osl-incubator / makim

Make Improved
https://osl-incubator.github.io/makim/
BSD 3-Clause "New" or "Revised" License
8 stars 10 forks source link

docs: add small section about xonsh and fix old style documentation #60

Closed abhijeetSaroha closed 10 months ago

abhijeetSaroha commented 10 months ago

resolve #44

xmnlab commented 10 months ago

@abhijeetSaroha ,

the CI pointed some style issue here https://github.com/osl-incubator/makim/actions/runs/6859379368/job/18659921382?pr=60#step:6:15

that means that the file you changed need to ends with one empty new line (some information here https://gist.github.com/OleksiyRudenko/d51388345ea55767b7672307fe35adf3)

abhijeetSaroha commented 10 months ago

Hi @xmnlab , I have resolved the issue, can you please check it.

xmnlab commented 10 months ago

@abhijeetSaroha , that looks great! thanks!

just one last thing, could you keep the line with less than 80 characters please? if you are using vscode there are some autoformatter for markdown that can help you I don't remember if prettier can handle markdown as well

abhijeetSaroha commented 10 months ago

@xmnlab done that, could you please check now?

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: