search

osl-incubator / scicookie

Cookiecutter template for a Python package.
https://osl-incubator.github.io/scicookie
Other
11 stars 18 forks source link

Update Pull Request Template to Ensure Proper Linking with Issues #217

Closed Naman-Priyadarshi closed 7 months ago

Naman-Priyadarshi commented 7 months ago

~ Date you used Cookiecutter Python Package:~ ~ Cookieninja version used, if any:~ ~ Python version, if any:~ ~ Operating System:~

Description

The Pull request template for both scicookie and the template uses solves #xyz instead of fixes #xyz which doesn't link the pull request to the issue. A very small change could help in making the process much smoother

agriyakhetarpal commented 7 months ago

I think https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword does list solves, doesn't it? edit: ah no it doesn't, the closest keyword is resolves

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 0.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: