osl-incubator / scicookie

Cookiecutter template for a Python package.
https://osl-incubator.github.io/scicookie
Other
10 stars 18 forks source link

docs(update): fixed theme issues and updated mkdocs-jupyter #270

Closed Naman-Priyadarshi closed 2 months ago

Naman-Priyadarshi commented 2 months ago

Pull Request description

Added dark-light mode toggle switch to documentation and updated mkdocs-jupyter to 0.24.7

Fixes #261

How to test these changes

mkdocs serve

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved
Naman-Priyadarshi commented 2 months ago

I changed the accent from amber to lime, let me know if you want me to change it back

xmnlab commented 2 months ago

@Naman-Priyadarshi , looks good to me.

I just fixed the CI. could you rebase your branch on top of the upstream main, please?

Naman-Priyadarshi commented 2 months ago

I think not changing the colour of the top bar is in advantage here, as our current (temporary) logo is not visible with a dark background.

Saransh-cpp commented 2 months ago

Oh I see, thanks!

xmnlab commented 2 months ago

thanks @Naman-Priyadarshi for working on that! thanks @Saransh-cpp for the review!

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: