imp: identation of the dependencies in the pyproject.toml file for the different build systems

osl-incubator / scicookie

Cookiecutter template for a Python package.

https://osl-incubator.github.io/scicookie

Other

10 stars 18 forks source link

imp: identation of the dependencies in the pyproject.toml file for the different build systems #271

Closed YurelyCamacho closed 2 months ago

YurelyCamacho commented 2 months ago

Pull Request description

Fixes: #154

Pull Request checklists

This PR is a:

[X] bug-fix
[ ] new feature
[ ] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Reviewer's Checklist

[ ] I managed to reproduce the problem locally from the main branch
[ ] I managed to test the new changes locally
[X] I confirm that the issues mentioned were fixed/resolved

xmnlab commented 2 months ago

I just fixed the CI. it seems you now have some git conflict in 2 files, could you rebase your branch on top of the upstream main, please? thanks

YurelyCamacho commented 2 months ago

@xmnlab Can you check it again?

xmnlab commented 2 months ago

@YurelyCamacho , just checking the CI I cannot say what is wrong. you need to debug it locally to check what is going wrong. let me know if you need help for debugging locally

YurelyCamacho commented 2 months ago

@xmnlab No, I'm already doing it. It's something with the changes you made yesterday. I'm already working it out. I'll let you know

xmnlab commented 2 months ago

@YurelyCamacho , I don't think it is related with the changes i made yesterday, otherwise this PR https://github.com/osl-incubator/scicookie/pull/270 would have the same issue.

YurelyCamacho commented 2 months ago

@xmnlab For some - that you added in some jinja statements that remove spaces and that's why the error occurred. When merging the changes the error occurred in the form of deleting spaces

xmnlab commented 2 months ago

@YurelyCamacho , sorry, I am not following you.

if you check it here: https://github.com/osl-incubator/scicookie/commits/main/

my PR when was merged, the CI passed the CI for the next PR with my changes also passed.

so the issue in on your PR, maybe when you rebased the changes from upstream/main it had some issues with the new changes.

YurelyCamacho commented 2 months ago

@xmnlab Don't worry, it's because of the conflict that existed (I'm giving a new approach to indentation).

YurelyCamacho commented 2 months ago

@xmnlab @Anavelyz If you can take a look at it please.

xmnlab commented 2 months ago

thanks @YurelyCamacho , I will play with that locally tomorrow :)

YurelyCamacho commented 2 months ago

@xmnlab great, thanks

xmnlab commented 2 months ago

that looks great! thanks @YurelyCamacho

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.8.0 :tada:

The release is available on:

0.8.0
GitHub release

Your semantic-release bot :package::rocket: