Add: pyos profile to cookie - Githubissues

osl-incubator / scicookie

Cookiecutter template for a Python package.

https://osl-incubator.github.io/scicookie

Other

10 stars 18 forks source link

Add: pyos profile to cookie #273

Open lwasser opened 2 months ago

lwasser commented 2 months ago

Pull Request description

This is a PR that adds a pyOpenSci profile to the osl cookiecutter!

How to test these changes

scicookie --profile pyos

Pull Request checklists

This PR is a:

[ ] bug-fix
[x] new feature
[ ] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

xmnlab commented 2 months ago

hey @lwasser , thanks for working on that!

I just fixed that issues you pointed me yesterday, and I cut a new release as well. please, feel free to ping me anytime if you have any question, comment or recommendation :)