osl-incubator / scicookie

Cookiecutter template for a Python package.
https://osl-incubator.github.io/scicookie
Other
10 stars 18 forks source link

fix: Add nodejs-wheel as a dependency #276

Closed xmnlab closed 2 months ago

xmnlab commented 2 months ago

Pull Request description

This PR adds nodejs-wheel as a dependency. It will help us to ensure that the user will have nodejs locally, so we can use nodejs tools to help us in some tasks (like prettier, for example)

How to test these changes

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved
xmnlab commented 2 months ago

@Saransh-cpp @EverVino @Anavelyz @YurelyCamacho , this PR aims to ensure that the user has nodejs locally. later we can add more auto-formatter tools in the post hook .. so it will keep our lives here easier :)

I need to merge this ASAP, but feel free to add any notes here and I can handle that later. thanks!

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 0.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: