feat(tui): Implement conditional option

Anavelyz commented 2 months ago

Pull Request description

If a user chooses certain options, this may lead to a new question or new options. To do this, it was necessary to implement the conditional option in ui.py.

Fixes #171

Pull Request checklists

This PR is a:

[ ] bug-fix
[x] new feature
[ ] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Reviewer's Checklist

[ ] I managed to reproduce the problem locally from the main branch
[ ] I managed to test the new changes locally
[ ] I confirm that the issues mentioned were fixed/resolved

xmnlab commented 1 month ago

It is a good progress @Anavelyz ! thanks for working on that

checking the workflow, I think that if the user decide to not configure git, it should not add anything with git.

it will be a bit challenge ... but at least I think you should review https://github.com/osl-incubator/scicookie/blob/main/src/scicookie/hooks/post_gen_project.py#L328

maybe it should abort or skip the git commands there

maybe it should also remove the .github folder

xmnlab commented 1 month ago

does it make sense?

Anavelyz commented 1 month ago

This was an attempt to resolve issue #171, unfortunately it was not successful 😞 so I will close the PR.

osl-incubator / scicookie