osl-incubator / scicookie

Cookiecutter template for a Python package.
https://osl-incubator.github.io/scicookie
Other
10 stars 18 forks source link

fix: Fix support for pipx #286

Closed xmnlab closed 1 month ago

xmnlab commented 1 month ago

Pull Request description

How to test these changes

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved
agriyakhetarpal commented 1 month ago

Note: I tested with pipx install based on a discussion from this thread: https://github.com/pypa/pipx/issues/812, let me test with pipx run as well.

xmnlab commented 1 month ago

thanks @agriyakhetarpal and @Saransh-cpp for the review! appreciate that.

@agriyakhetarpal , I didn't test it with pipx install, just with the pipx run, so I think we are good to merge this :) but feel free to ping me if you have any issue!

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 0.8.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: