osl-incubator / scicookie

Cookiecutter template for a Python package.
https://osl-incubator.github.io/scicookie
Other
10 stars 18 forks source link

ci(caching): add cache for conda environment in template ci #301

Open Naman-Priyadarshi opened 1 week ago

Naman-Priyadarshi commented 1 week ago

Pull Request description

Implemented caching for conda environment in template's ci Fixes #102

How to test these changes

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved
Naman-Priyadarshi commented 1 week ago

Hi @xmnlab, How should I define the matrix.os here? The solution we use in scicookie's ci is

tests:
    strategy:
      matrix:
        os:
          - "ubuntu"
          - "macos"
          - "windows"

    runs-on: ${{ matrix.os }}-latest

    concurrency:
      group: ci-main-tests-${{ matrix.os }}-${{ github.ref }}
      cancel-in-progress: true

So should we use a similar structure?

xmnlab commented 1 week ago

@Naman-Priyadarshi , ping me when this is ready again for review, thanks!