feat: Rename from sugar to core module name

osl-incubator / sugar

Simplify the usage of containers

https://osl-incubator.github.io/sugar/

BSD 3-Clause "New" or "Revised" License

7 stars 8 forks source link

feat: Rename from sugar to core module name #101

Closed esloch closed 10 months ago

esloch commented 11 months ago

Pull Request description

How to test these changes

...

Pull Request checklists

This PR is a:

[ ] bug-fix
[x] new feature
[x] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[ ] I have reviewed the changes and it contains no misspelling.
[ ] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

xmnlab commented 11 months ago

@esloch I just merged this PR: https://github.com/osl-incubator/sugar/pull/102 could you rebase your branch on top of the upstream main?

esloch commented 11 months ago

@esloch I just merged this PR: #102 could you rebase your branch on top of the upstream main?

I think that we need to update the poetry.lock.

xmnlab commented 11 months ago

Could you remove and recreate it please?

esloch commented 11 months ago

Could you remove and recreate it please?

I removed the "poetry.lock" and then run the "poetry update":

(sugar) ✔ /workspace/repos/osl/sugar [rename-module|● 1] 
21:39 $ poetry update
Updating dependencies
Resolving dependencies... (65.4s)

The current project's Python requirement (>=3.8.1) is not compatible with some of the required packages Python requirement:
  - makim requires Python >=3.8.1,<4.0.0, so it will not be satisfied for Python >=4.0.0

Because containers-sugar depends on makim (1.8.3) which requires Python >=3.8.1,<4.0.0, version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For makim, a possible solution would be to set the `python` property to ">=3.8.1,<4.0.0"

xmnlab commented 11 months ago

@esloch the issue with the installation was fixed (I hope!) now the error is about the tests.

esloch commented 11 months ago

@esloch the issue with the installation was fixed (I hope!) now the error is about the tests.

Thanks Ivan!

xmnlab commented 11 months ago

@esloch , just cut a new release. please, rebase your branch on top of the upstream main

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

1.10.0
GitHub release

Your semantic-release bot :package::rocket: