osl-incubator / sugar

Simplify the usage of containers
https://osl-incubator.github.io/sugar/
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

bug: Check if project-name is null #106

Closed joel5vega closed 11 months ago

joel5vega commented 11 months ago

Pull Request description

Issue #28

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .
joel5vega commented 11 months ago

@xmnlab , I've added one conditional to check if project-name is null, please check if it is implemented correctly

joel5vega commented 11 months ago

Sure @xmnlab , I will correct and update it!

xmnlab commented 11 months ago

The CI is still failing about distlib issue. I will work on that later. But for now this PR looks good to me. Thanks

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: