refactor: change to dictionary format

osl-incubator / sugar

Simplify the usage of containers

https://osl-incubator.github.io/sugar/

BSD 3-Clause "New" or "Revised" License

6 stars 8 forks source link

refactor: change to dictionary format #97

Closed joel5vega closed 9 months ago

joel5vega commented 9 months ago

changed from -name:name to name:

Pull Request description

Change to dictionary format

refactor: Issue #43

Pull Request checklists

This PR is a:

[ ] bug-fix
[ ] new feature
[X] maintenance

About this PR:

[ ] it includes tests.
[ ] the tests are executed on CI.
[ ] the tests generate log file(s) (path).
[ ] pre-commit hooks were executed locally.
[ ] this PR requires a project documentation update.

Author's checklist:

[X] I have reviewed the changes and it contains no misspelling.
[X] The code is well commented, especially in the parts that contain more complexity.
[ ] New and old tests passed locally.

Additional information

We may need to update sugar.py as well

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

xmnlab commented 9 months ago

please also update the documentation: https://github.com/osl-incubator/containers-sugar/blob/main/docs/index.md

xmnlab commented 9 months ago

https://github.com/osl-incubator/makim/pull/28

PS: __main__.py would be the "same" as our cli.py

joel5vega commented 9 months ago

osl-incubator/makim#28

PS: __main__.py would be the "same" as our cli.py It seems that _main__.py is now in makim.py and it can be compared with sugar.py

xmnlab commented 9 months ago

@joel5vega thanks for working on that!

the linter is failing: https://github.com/osl-incubator/sugar/actions/runs/7268534099/job/19804578232?pr=97#step:5:17

in order to fix that, please run the following commands (within the sugar environment):

pre-commit install
pre-commit run --all-files
pre-commit run --all-files  # yes, run it twice to check if all the files were fixed.

because this issue was triggered by ruff-format, it will be fixed automatically .. the other hooks when fail, need to be fixed manually.

ping if you have any question

joel5vega commented 9 months ago

Great, it is updated

El mar, 19 dic 2023 a la(s) 9:58 p.m., Ivan Ogasawara ( @.***) escribió:

@joel5vega https://github.com/joel5vega thanks for working on that!

the linter is failing: https://github.com/osl-incubator/sugar/actions/runs/7268534099/job/19804578232?pr=97#step:5:17

in order to fix that, please run the following commands (within the sugar environment):

pre-commit install pre-commit run --all-files pre-commit run --all-files # yes, run it twice to check if all the files were fixed.

because this issue was triggered by ruff-format, it will be fixed automatically .. the other hooks when fail, need to be fixed manually.

ping if you have any question

— Reply to this email directly, view it on GitHub https://github.com/osl-incubator/sugar/pull/97#issuecomment-1863730501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGTH6KAS7DTBKCQDYWKYVOTYKJA2TAVCNFSM6AAAAABAQPPZWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTG4ZTANJQGE . You are receiving this because you were mentioned.Message ID: @.***>

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 1.9.3 :tada:

The release is available on:

1.9.3
GitHub release

Your semantic-release bot :package::rocket: