search

oslego / chrome-backspace-back

Google Chrome extension that restores browser behavior of navigating to previous page when pressing the Backspace key.
76 stars 7 forks source link

Problem with using TFS (Visual Studio Team Foundation Server) #12

Open derekantrican opened 7 years ago

derekantrican commented 7 years ago

As a developer, I use Visual Studio Team Foundation Server (TFS) all the time. I have found recently that when I am editing the description of a bug or feature and press the backspace key, the "Backspace to go Back" extension kicks in. I have not investigated the code, but I imagine this is something along the lines of it not recognizing that I a HTML element is actively being edited?

Here is a YouTube video of the problem: http://www.youtube.com/watch?v=VU6FYETkk0o

oslego commented 7 years ago

Hi @derekantrican! Thanks for logging this and for making the video. I will look into it.

The extension encounters false positives when the active element is not of type INPUT or TEXTAREA.

On some websites, what seems to be an input is actually a simulation of one, so the extension's checks fail and it triggers.

Another case where it fails are normal inputs wrapped in ShadowDOM within a Custom Element. In those scenarios, the activeElement is the host custom element, not the input, hence the check fails.

The TFS case falls in one of those two scenarios. I will investigate soon.

derekantrican commented 7 years ago

Would it be helpful if I provided the HTML of the page next time I encounter this issue?

oslego commented 7 years ago

The URL of the page, if publicly accessible, is helpful. The plain HTML won't help much as there are usually interactions with some JS code on the page.

derekantrican commented 7 years ago

Unfortunately it will not be publicly accessible. Is there any other information I should try to capture and put here when I see this problem next?