search

oslllo / svg-fixer

Converts SVG Strokes To Fill.
https://docs-oslllo-com.onrender.com/svg-fixer/master
MIT License
213 stars 19 forks source link

Getting Error: Missing required arguments: source, destination #57

Closed ayusman33 closed 3 years ago

ayusman33 commented 3 years ago

Hi I am getting Missing required arguments: source, destination error when running: npm run oslllo-svg-fixer

JS File: const SVGFixer = require('oslllo-svg-fixer');

const options = { showProgressBar: true, throwIfDestinationDoesNotExist: true, };

SVGFixer('./svg', './updated-svg', options);

Pls let me know if I am missing anything

ayusman33 commented 3 years ago

I got it fixed

Ghustavh97 commented 3 years ago

@ayusman33 how did you fix it?

ayusman33 commented 3 years ago

Just followed the steps mentioned.

ayusman33 commented 3 years ago

Just followed the steps mentioned.

But one thing I noticed is: while converting to fix; it changes the fill color. Do we know why?

Ghustavh97 commented 3 years ago

It depends on how the fill color was set. Can you post and example of the broken icon?

ayusman33 commented 3 years ago

This is the original which I tried to convert: image

After Conversion: image

See the fill color is changed

Ghustavh97 commented 3 years ago

Raw code would be better, also what application do you use to create the icons?

ayusman33 commented 3 years ago

Raw code would be better, also what application do you use to create the icons?

I am unable to paste the raw code. We use grunt webfont

ayusman33 commented 3 years ago

<?xml version="1.0" encoding="UTF-8"?>

Fixed:

ayusman33 commented 3 years ago

See it does not take the code and shows empty

ayusman33 commented 3 years ago

Share your email; will mail you

Ghustavh97 commented 3 years ago
  1. Is this the svg after you pass it into grunt? If so I want the original svg before grunt. If not what I meant the application that was used to create the svg as in were it was drawn or downloaded from.
  2. Put ``` before and after the code to make it show up
ayusman33 commented 3 years ago

Before:

<?xml version="1.0" encoding="UTF-8"?>
<svg viewBox="0 0 20 20" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <g id="close-circle" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
        <g id="hol_close_circle">
            <circle id="Oval" stroke="#B42025" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round" cx="10" cy="10" r="7.25"></circle>
            <line x1="7" y1="13" x2="13" y2="7" id="Path" stroke="#B42025" stroke-width="1.5" stroke-linejoin="round"></line>
            <line x1="7" y1="7" x2="13" y2="13" id="Path" stroke="#B42025" stroke-width="1.5" stroke-linejoin="round"></line>
        </g>
    </g>
</svg>

After:

<svg viewBox="0 0 20 20" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="M9.467 2.022 C 8.274 2.136,7.428 2.366,6.483 2.833 C 5.644 3.247,4.999 3.705,4.368 4.334 C 3.706 4.995,3.247 5.636,2.832 6.483 C 2.270 7.628,2.019 8.713,2.019 10.000 C 2.019 11.288,2.270 12.374,2.832 13.517 C 3.246 14.358,3.702 14.998,4.352 15.648 C 5.001 16.296,5.634 16.748,6.483 17.167 C 8.741 18.282,11.351 18.269,13.601 17.131 C 15.176 16.335,16.377 15.117,17.167 13.517 C 17.729 12.380,17.981 11.289,17.981 10.000 C 17.981 8.712,17.730 7.626,17.168 6.483 C 16.152 4.418,14.356 2.921,12.146 2.300 C 11.329 2.071,10.192 1.952,9.467 2.022 M10.693 3.535 C 12.146 3.694,13.447 4.304,14.496 5.316 C 15.100 5.900,15.457 6.387,15.832 7.140 C 16.915 9.317,16.674 11.913,15.203 13.900 C 14.975 14.207,14.430 14.776,14.116 15.033 C 13.143 15.831,11.935 16.331,10.650 16.469 C 10.251 16.512,9.395 16.493,9.033 16.434 C 7.663 16.210,6.494 15.633,5.523 14.702 C 4.914 14.118,4.543 13.614,4.168 12.860 C 2.833 10.177,3.533 6.931,5.867 4.984 C 7.185 3.884,8.973 3.347,10.693 3.535 M7.000 7.017 L 6.484 7.534 7.717 8.767 L 8.950 10.000 7.717 11.233 L 6.484 12.467 7.008 12.992 L 7.533 13.516 8.767 12.283 L 10.000 11.050 11.233 12.283 L 12.467 13.516 12.992 12.992 L 13.516 12.467 12.283 11.233 L 11.050 10.000 12.283 8.767 L 13.516 7.533 12.992 7.008 L 12.467 6.484 11.233 7.717 L 10.000 8.950 8.775 7.725 C 8.101 7.051,7.542 6.500,7.533 6.500 C 7.523 6.500,7.284 6.733,7.000 7.017 " stroke="none" fill="black" fill-rule="evenodd"></path></svg>
Ghustavh97 commented 3 years ago
  1. Is this the svg after you pass it into grunt? If so I want the original svg before grunt. If not what I meant the application that was used to create the svg as in were it was drawn or downloaded from.

@ayusman33

ayusman33 commented 3 years ago

@Ghustavh97 Apologies for replying late. Yes.