oslocyclotronlab / Talys-code

The TALYS code
MIT License
1 stars 0 forks source link

Multiple PDR peaks doesn't work #2

Open vetlewi opened 2 years ago

vetlewi commented 2 years ago

In the documentation, TALYS supports up to two PDR peaks. However, TALYS will only use the first peak.

cecgresonant commented 2 years ago

That's a bad bug.. Did you write to the Stephane's about it?

vetlewi commented 2 years ago

That's a bad bug.. Did you write to the Stephane's about it?

No, not yet. But I have a fix, see 1ec60de71c78a74cca4e5bae402b157f6558d88f

In addition, I'd like to add a change in the code where TALYS writes the output file to ensure that all PDR parameters are properly written. This will require:

vetlewi commented 2 years ago

To be clear, the issue is as following. If you add two E1 PDR to the strength function of a given nucleus, say 145Nd you'd write in the input to TALYS

epr 60 145 7.5 E1 1
spr 60 145 1.5 E1 1
gpr 60 145 0.9 E1 1

epr 60 145 9.5 E1 2
spr 60 145 12.2 E1 2
gpr 60 145 1.2 E1 2

And you'd expect there to be two standard Lorentzians added to the E1 strength with the given parameters. However, TALYS only uses the first set of parameters (the ones marked with 1), thus only one extra Lorentzian is added to the E1 strength.

This is contrary to the documentation (user manual).