search

oslocyclotronlab / ompy

A python implementation of the Oslo method
https://ompy.readthedocs.io
GNU General Public License v3.0
6 stars 7 forks source link

Fixed bad assertion #193

Closed vetlewi closed 3 years ago

vetlewi commented 3 years ago

The assertion compared floating point numbers. To avoid round-off errors we now use np.isclose to compare the two numbers. Closes issue #181.

vetlewi commented 3 years ago

Could @fzeiser or @ErlendLima merge this?

ErlendLima commented 3 years ago

I'll merge it. Do you also want admin role? Minor fixes like this can skip review, while larger additions or changes should require review by at least one (other) admin.

ErlendLima commented 3 years ago

Or write role, if you don't want the connotation of maintainer of ompy.

vetlewi commented 3 years ago

Or write role, if you don't want the connotation of maintainer of ompy.

Would prefer writer for now😅