search

oslocyclotronlab / ompy_Archive_Sept2019

Archived version om ompy as of 27. Sept 2019 -- Please use this instead:
https://github.com/oslocyclotronlab/ompy/
GNU General Public License v3.0
0 stars 1 forks source link

Threshold in response matrix #2

Closed fzeiser closed 5 years ago

fzeiser commented 5 years ago

Issue by fzeiser Thursday Aug 23, 2018 at 14:40 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/2

I wanted to make sure that we take into account the experimental threshold properly. I think you do this with the following lines (where however you have a hardcoded threshold of 30 keV, which seems a little low to me)

https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/response.py#L143-L149

https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/response.py#L181-L186

Do I understand it correctly, that you define an array of mid-oint energies, Eout_array, that has a threshold Egmin? In following two lines https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/response.py#L185-L186 you then only take cmp events that are above threshold, right?

So by the time you create the normalization sum for all events, https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/response.py#L192-L194 you have automatically taken into account the threshold, right?

fzeiser commented 5 years ago

Comment by fzeiser Friday Aug 24, 2018 at 14:16 GMT

Ok, well, it's also important to take into account the (total) efficiency, so currently this is here, isn't it? https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/unfold.py#L430

Am I assuming correctly, that this shall then be converted to be taken from Eff_tot https://github.com/jorgenem/oslo_method_python/blob/9c3d11d882d26f9ddfb3dc04bb852dc89c6157ba/response.py#L109 when using generating an "own" response

Note that eff_tot here does currently not include any threshold! So it's all counts in the simulated spectrum, also those below the threshold, divided by the number of simulated gamma-rays.

fzeiser commented 5 years ago

Comment by jorgenem Monday Aug 27, 2018 at 08:54 GMT

Thanks for the scrutiny! This is super useful. I want to get back to you when I've gotten the interpolation sorted out, because a lot of this is currently written straight off MAMA, and there are parts I don't fully understand -- such as the 30 keV hard threshold. I would love to discuss it with you at some point in the near future.

fzeiser commented 5 years ago

Comment by fzeiser Monday Sep 09, 2019 at 10:07 GMT

Decided in #38 (once merged in) not to put any additional threshold on the responses. It doesn't seems to have any effect anyhow.