oslocyclotronlab / ompy_Archive_Sept2019

Archived version om ompy as of 27. Sept 2019 -- Please use this instead:
https://github.com/oslocyclotronlab/ompy/
GNU General Public License v3.0
0 stars 1 forks source link

Restructure build requirements for Cython #29

Closed fzeiser closed 5 years ago

fzeiser commented 5 years ago

Issue by fzeiser Thursday Aug 29, 2019 at 10:11 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/29


When trying to install ompy without having numpy or cython, one would currently get an error similar to this:

 magneg@fysmac-kef12.uio.no:ompy-master>python setup.py build_ext --inplace
Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    from Cython.Build import cythonize
ImportError: No module named Cython.Build

This is because setup.py imports numpy or cython in the start. This should be restructured, such that you get a better error message or the dependecies are installed/ or should be mentioned in readme.

Potential fix: https://stackoverflow.com/questions/55598951/how-to-make-cython-a-requirement-for-a-pip-install

fzeiser commented 5 years ago

Comment by fzeiser Tuesday Sep 03, 2019 at 08:32 GMT


Fixed in a28b2ce5f6f36f19f50d5159e5a69321aaf9dca3