search

oslocyclotronlab / ompy_Archive_Sept2019

Archived version om ompy as of 27. Sept 2019 -- Please use this instead:
https://github.com/oslocyclotronlab/ompy/
GNU General Public License v3.0
0 stars 1 forks source link

Bugs in gauss_smoothing #36

Open fzeiser opened 5 years ago

fzeiser commented 5 years ago

Issue by fzeiser Saturday Sep 07, 2019 at 07:24 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/36

Bug 1) https://github.com/oslocyclotronlab/ompy/blob/fc4ddfb1d53f9ac9924446dc3a1bd063ee7a8abe/ompy/gauss_smoothing.pyx#L144-L145

If input energies are in lower-bin edge, make sure that this is correct!

Bug 2) Make sure that gauss_smoothing converts FWHMs to (/per bin) -> Oups: noticed that this is not necessary, as we implemented an own gauss, and do not use gaussian_smoothing_1D or whatever the function in numpy is called

fzeiser commented 5 years ago

Comment by fzeiser Saturday Sep 07, 2019 at 07:29 GMT

Still, double check we get the right smoothing. It seems to be that the FWHMs are not read correctly.

fzeiser commented 5 years ago

Comment by fzeiser Sunday Sep 08, 2019 at 05:38 GMT

As in #20, it was basically just a mistake in how I interpreted the api. I'll change the input from *realative FHWM in %" to the absolute FWHM. I think this is much more common!

fzeiser commented 5 years ago

Comment by fzeiser Monday Sep 09, 2019 at 09:55 GMT

Changed to absolute FWHM in b15ecf11fd99742da499f2f9aa9bffbe330f40c. Waiting for merge in of the #38.