We ought to go through the code and check where mid bin are used vs where lower bins are used. I still don't see where the lower bin edges are useful.
Some places, like in the multiplicity estimations, we currently do it wrong. Not that it was a huge effect for small enough bins, but it has an effect. See eg:
Where it the calculations proceed as if mid_bin energies were used. I guess it could be best to decide with version to use soon ;P. Anyhow, one could have a convenience function converting lower to bin bins.
How about the possibility that the matrices have variable bin sizes?
This should be fixed before further comparison in #32
We ought to go through the code and check where mid bin are used vs where lower bins are used. I still don't see where the lower bin edges are useful.
Some places, like in the multiplicity estimations, we currently do it wrong. Not that it was a huge effect for small enough bins, but it has an effect. See eg:
https://github.com/oslocyclotronlab/ompy/blob/b1011b397b10b7609111a4c9a4bb48e22f36692b/ompy/firstgeneration.py#L226-L241
Where it the calculations proceed as if mid_bin energies were used. I guess it could be best to decide with version to use soon ;P. Anyhow, one could have a convenience function converting lower to bin bins.
This should be fixed before further comparison in #32