oslocyclotronlab / ompy_Archive_Sept2019

Archived version om ompy as of 27. Sept 2019 -- Please use this instead:
https://github.com/oslocyclotronlab/ompy/
GNU General Public License v3.0
0 stars 1 forks source link

NLD binwidth in `extractor`'s decomposition function is wrong #45

Closed fzeiser closed 5 years ago

fzeiser commented 5 years ago

Issue by fzeiser Thursday Sep 26, 2019 at 20:45 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/45


NLD binwidth in extractor's decomposition function is wrong. np.linspace wants the number of steps, not the binwidth. This is probably also the reason for the strange behavior of the decomposed nld and gsf in 95d4523, getting_started notebook.

https://github.com/oslocyclotronlab/ompy/blob/95d4523fbe451cb861a74e5b6db757c8972ecfff/ompy/extractor.py#L201-L203