Closed fzeiser closed 5 years ago
Issue by fzeiser Thursday Sep 26, 2019 at 20:45 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/45
NLD binwidth in extractor's decomposition function is wrong. np.linspace wants the number of steps, not the binwidth. This is probably also the reason for the strange behavior of the decomposed nld and gsf in 95d4523, getting_started notebook.
extractor
np.linspace
getting_started
https://github.com/oslocyclotronlab/ompy/blob/95d4523fbe451cb861a74e5b6db757c8972ecfff/ompy/extractor.py#L201-L203
Issue by fzeiser Thursday Sep 26, 2019 at 20:45 GMT Originally opened as https://github.com/oslocyclotronlab/ompy/issues/45
NLD binwidth in
extractor
's decomposition function is wrong.np.linspace
wants the number of steps, not the binwidth. This is probably also the reason for the strange behavior of the decomposed nld and gsf in 95d4523,getting_started
notebook.https://github.com/oslocyclotronlab/ompy/blob/95d4523fbe451cb861a74e5b6db757c8972ecfff/ompy/extractor.py#L201-L203