search

osm-ToniE / ptna

Public Transport Network Analysis for OSM
GNU General Public License v3.0
21 stars 5 forks source link

Wrong reports when there is more than one route_master for a 'ref' #1

Closed osm-ToniE closed 6 years ago

osm-ToniE commented 6 years ago

Tool does not at all or reports only once or even twice for a specific route_master relation when there is more than one route_master for this "ref".

See busses of DE-HB-VBN 304, 306, 307, 308, 310, 311, 314, 315, 317, 318, 321, 322, 323, 324 as of 20:21, 25. Feb. 2018‎

Bus 304 route_master {{Relation 3767311}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
'public_transport:version' is not set		 'network' is short form
Bus 304 route_master {{Relation 5488560}} align="center" ? 'network' is not set
'public_transport:version' is not set
-
Bus 306 route_master {{Relation 447879}} align="center" ? 'public_transport:version' is not set 'network' is short form
Bus 306 route_master {{Relation 5488561}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
'network' is not set
'public_transport:version' is not set
-
Bus 307 route_master {{Relation 3768321}} align="center" ? 'public_transport:version' is not set 'network' is short form
Bus 307 route_master {{Relation 5488562}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
'network' is not set
'public_transport:version' is not set
-
Bus 308 route_master {{Relation 3770400}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (8 versus 4) in the given data set
'public_transport:version' is not set		 'network' is short form
Bus 308 route_master {{Relation 5488563}} align="center" ? 'network' is not set
'public_transport:version' is not set
-
Bus 310 route_master {{Relation 3749333}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (18 versus 9) in the given data set
'public_transport:version' is not set		 'network' is short form
Bus 310 route_master {{Relation 5488564}} align="center" ? 'network' is not set
'public_transport:version' is not set
-
Bus 317 route_master {{Relation 3785080}} align="center" ? 'public_transport:version' is not set 'network' is short form
Bus 317 route_master {{Relation 5488568}} align="center" ? There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
There is more than one Route-Master for this line
Route-Masters have more Routes than actually exist (4 versus 2) in the given data set
'network' is not set
'public_transport:version' is not set
-

...

osm-ToniE commented 6 years ago

Fix applied to the function analyze_route_master_environment().

$relation_ref should have been a fixed pointer to the relation under examination. Instead the variable wasn't set at all and overwritten in the for loop. The final value was not predictable.