search

osm-americana / openstreetmap-americana

A quintessentially American map style
https://americanamap.org
Creative Commons Zero v1.0 Universal
185 stars 61 forks source link

Shield icons mismatched in taginfo #1155

Closed claysmalley closed 2 months ago

claysmalley commented 2 months ago

The Taginfo project page is displaying the wrong icons for various values of network=*:

image

ZeLonewolf commented 2 months ago

I'm wondering if this could be a CDN caching thing. I believe the filenames are generated with an incrementing number, so they might change if new designs get added.

ZeLonewolf commented 2 months ago

These shields are pushed to github pages, e.g.: https://americanamap.org/shield-sample/shield_24.svg

If we change the shield designs it'll be a day lag before the new taginfo file catches up. That could be one possible issue, but I don't think we changed those recently?

ZeLonewolf commented 2 months ago

Ok so I'm looking at taginfo now and things seem correct, can someone confirm?

1ec5 commented 2 months ago

Yes, looks good to me. Do we want to change the format to be more resilient to such changes, or is it not a big enough deal to fuss over?

ZeLonewolf commented 2 months ago

yes, ideally the format should use names with substrings like "_bluepentagon" and not rely on an arbitrary numbering system. Although this is a pretty minor issue.

claysmalley commented 2 months ago

Closing this for now. If it happens again, let's consider a more error-proof way of naming these icons.