osm-americana / openstreetmap-americana

A quintessentially American map style
https://americanamap.org
Creative Commons Zero v1.0 Universal
183 stars 60 forks source link

Clarify guidelines for adding shield support for new countries #461

Open claysmalley opened 2 years ago

claysmalley commented 2 years ago

There's been a wave of contributions lately, adding route shield support for non-US countries. We should make it more obvious what the prerequisites are for supporting route=road tagging schemes in OSM-Americana.

Some guidelines off the top of my head:

1ec5 commented 2 years ago

The value of ref= must not contain extra text (prefixes or suffixes) that needs to be removed before displaying. Likewise, it must not require a hardcoded prefix or suffix to be added. We must be able to show ref= directly as the route number on the shield, without preprocessing.

This has come up as a problem enough times that I wonder if we should formally propose it as a standard on the wiki. The “without preprocessing” part is critical: there may be some resistance to the idea of tailoring ref tags to Americana’s needs, but it’s possible to express the same requirement in more basic terms. In principle, ref should only include a prefix that’s an integral part of the route number, not just for the purpose of disambiguation in certain OSM contexts. The rationale is to avoid the same proliferation of haphazard, often proprietary ref processing rules for route relations as has already occurred for ways.

claysmalley commented 2 years ago

Should we resolve #141 as won't fix?

1ec5 commented 2 years ago

Should we resolve #141 as won't fix?

I don’t find that issue’s original rationale very compelling, given the rabbit hole we’d find ourselves in, but we will run into some need for concatenation and possibly numeral conversion: https://github.com/ZeLonewolf/openstreetmap-americana/issues/141#issuecomment-1046409219.

zekefarwell commented 2 years ago

This has come up as a problem enough times that I wonder if we should formally propose it as a standard on the wiki. The “without preprocessing” part is critical

Somehow I thought the wiki already stated that ref on a route relation should be the value most commonly used on signage (no extra prefixes or suffixes). I just looked around and couldn't find such a statement though. We certainly should add this somewhere on the wiki, though I'm not sure where would be most appropriate.

1ec5 commented 2 years ago

I added a brief mention in the examples section of the ref documentation back in 2014, but it’s easy to overlook.