search

osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
89 stars 113 forks source link

Add additional undefined key(s) of value "yes" #1446

Open danieldegroot2 opened 2 years ago

danieldegroot2 commented 2 years ago

Some additional keys with the value "yes" should be specified further, changed or removed.

Example(s): location(, construction; deprecated, replace by construction=minor, or construction:*)

(Browse MapRoulette)

(Irrelevant: area)

Famlam commented 2 years ago

A large amount of these is already present in http://osmose.openstreetmap.fr/nl/issues/open?item=9002 (i.e. via the JOSM validator rules). 

aerialway=yes
amenity=yes
barrier=yes
craft=yes
landuse=yes
leisure=yes
manhole=yes
place=yes
playground=yes
police=yes
service=yes
sidewalk=yes
shop=yes
traffic_calming=yes

(here I left out the exceptions, like shop=yes for amenity=fuel) I don't see how it would be possible to make a generic check for *=yes, since there's plenty of keys where *=yes is a valid or accepted value. (For instance, building=yes in the absence of a widespread tagging scheme for mixed-purpose buildings)

frodrigo commented 2 years ago

So, completion should be proposed to JOSM validator

cc @Klumbumbus