osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
88 stars 109 forks source link

surveillance:type=* should be present if camera:*=* is #1840

Open ivanbranco opened 1 year ago

ivanbranco commented 1 year ago

Hi,

I would like to propose a new check. If an element is tagged with a camera:= prefix, it should have a surveillance:type=* value as well, usually =camera or =ALPR

Overpass query: https://overpass-turbo.eu/s/1upC

Famlam commented 1 year ago

https://wiki.openstreetmap.org/wiki/Key:camera:type Note it can also be used on shop=camera.

I personally would not be too enthusiastic about this test. I'm just thinking along the lines of:

ivanbranco commented 1 year ago

https://wiki.openstreetmap.org/wiki/Key📷type Note it can also be used on shop=camera.

This could be avoided by excluding camera:type and using only camera:mount, camera:angle and camera:direction

I would get extra warnings for missing surveillance:type.

Should this be a condition to keep in mind for warnings? I'm full of warnings that I will never fix just because I corrected a typo in the name somewhere where I can't check stuff on the ground. With this logic I shouldn't fix typos because I would get a warning.

Famlam commented 1 year ago

Agree, that last sentence should've been phrased differently, I'll remove it as it makes a wrong point. Primary point is that I like issues to be verifyable without needing inside information (especially since it's not bad tagging to not have the surveillance:type tag, it's just extra information, like a street without sidewalk tag). But it's only my opinion.

Marc-marc-marc commented 1 year ago

I don't see why surveillance:type=* is mandatory (otherwise with this logic, building:levels should be mandatory with building, and everyone should be able to add the info they want in mandatory from another tag) or a level 4 "mapcomplete"should be created (and disabled by default) to list all the current missing tag suggestions, a bit like StreetComplete

ivanbranco commented 1 year ago

otherwise with this logic, building:levels should be mandatory with building

This looks kinda the opposite to me, is like having building:levels= without building= If you have a tag that describes the building levels, but you don't have the building, something is wrong, don't you agree?

Same here, you have a tag that describes the camera properties, but you don't have the camera, since man_made=surveillance alone could be also a guard, to say one.

Famlam commented 1 year ago

If it's such a must-be-together combination we would probably forward you to JOSM to get it in their (and, after a synchronization, our) mapcss rules ;) .

I do stand by my point that it's not a good idea to add a rule for this as it's an (often) unverifiable property. camera:mount/camera:type etc implies it's a camera of any type. Whether it's a licence plate scanner camera or a general camera, as defined in surveillance:type, is, as Marc says, a nice addition, but not a must IMO.