osm-fr / osmose-backend

Part of osmose that runs the analysis, and send the results to the frontend.
GNU General Public License v3.0
94 stars 115 forks source link

False positives in Lithuania: 9004001 abbreviated street name #2120

Open AurimasF opened 10 months ago

AurimasF commented 10 months ago

https://osmose.openstreetmap.fr/lt/issues/open?country=lithuania&item=9004&source=&class=9004001

It looks like most (all?) issues in Lithuania are false positives. In Lithuania street ending "pl." is part of the official street name, not an error.

For example, see official Lithuanian address registry for a house address in a street named "Minsko pl.": https://www.regia.lt/map/regia2?x=585081&y=6057755&scale=2000&identify=true&lang=1

Famlam commented 10 months ago

I don't speak Lithuanian, but is pl. an abbreviation?

AurimasF commented 10 months ago

Yes, pl. is an abbreviation of plentas. However, all street names in Lithuania always end with an abbreviation (a. aklg. al. aplinkl. g. kel. krant. pl. pr. skg. skv. tak.).

frodrigo commented 10 months ago

This rule come from JOSM Validator https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/highway.mapcss

The global advice is generally to not use abbreviation https://wiki.openstreetmap.org/wiki/Abbreviations

AurimasF commented 10 months ago

This rule come from JOSM Validator https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/highway.mapcss Then it should be disabled for Lithuania, since it "works by accident" flagging only one of the possible street abbreviations.

I tracked abbreviation Pl back to: https://josm.openstreetmap.de/changeset/16439/osm/applications/editors/josm/plugins/validator/tagchecker.cfg https://josm.openstreetmap.de/ticket/2861extra suggestions from talk-au list.

The global advice is generally to not use abbreviation https://wiki.openstreetmap.org/wiki/Abbreviations Official addresses always use these abbreviations, official street signs use abbreviations.

Famlam commented 10 months ago

Then it should be disabled for Lithuania, since it "works by accident" flagging only one of the possible street abbreviations. & Official addresses always use these abbreviations, official street signs use abbreviations.

The convention in OSM is to write out abbreviations in the name tag, as shown on the link of Frodrigo. This of course doesn't stop you to add the official spelling to the official_name tag. It's worldwide like this. (Also in the Netherlands, we have streets called e.g. "Sint Anna" which are shown on street signs as "St. Anna", but the full name - and how you would pronounce it - is without abbreviations. Hence, the tagging is name=Sint Anna)

AurimasF commented 10 months ago

These abbreviations (a. aklg. al. aplinkl. g. kel. krant. pl. pr. skg. skv. tak.) are not for the street name, but for the road type:

frodrigo commented 10 months ago

Not using abbreviations is for street name and street type.

AurimasF commented 10 months ago

Not using abbreviations is for street name and street type. All maps in Lithuania use abbreviations in street names since it is the official form.

So for Osmose 9004001 issues there are two options?:

  1. Disable this check for Lithuania.
  2. Mark 1464 (and all later) issues as false positives.
Famlam commented 10 months ago

Please don't mark them as false positives, as they aren't. In OSM, (nearly) all abbreviations should be spelled out. So a boulevard is written as 'boulevard', not 'bvd' or 'bd'; a street is 'street', not 'st'.

You can disable the check in the menu on the left of Osmose for yourself.

frodrigo commented 10 months ago

It look like to my, only a small part of the streets have this issue. But its growing up over the time

https://osmose.openstreetmap.fr/lt/issues/graph.png?country=lithuania&item=9004&source=&class=9004001

The issues are only on some ways

https://osmose.openstreetmap.fr/lt/map/#country=lithuania&item=9004&source=&class=9004001&zoom=12&lat=54.8912&lon=23.9266&level=1%2C2%2C3

Famlam commented 10 months ago

But its growing up over the time

That may indicate that streets become more detailed and are thus split up. Anyway, I don't think there's anything we have to do here, right? If it should be fixed (which I don't think) it's JOSM who should do so.

AurimasF commented 10 months ago

It look like to my, only a small part of the streets have this issue. But its growing up over the time It is growing, because all suggested „fixes“ by Osmose or JOSM are actively reverted as they cause errors in addresses, since they are compared to the official address registry that uses official street names with abbreviations.

frodrigo commented 10 months ago

If local community have chosen to use abbreviations every where (despite the global advice) it can disabled in JOSM and /or Osmose. There is a link with that, eg on the wiki ?

AurimasF commented 10 months ago

I checked, the rule to „use abbreviated street names“ in Lithuanian community is implicit, unwritten, because:

  1. Official Lithuanian address registry uses abbreviations.
  2. It is what's on the ground.
Famlam commented 10 months ago

It is what's on the ground.

Do people on the ground pronounce it as "pl" or as "plentas"? If the latter, it's definitely an abbreviation. Of course you can put it in official_name=*, that's what that key is for (example from NL: https://www.openstreetmap.org/way/27173726 ). But well, if the local community decides otherwise, that's a different story.


Because yes, I see that there's 1453 ways with pl. and only 26 with Plentas (or plentas), so it seems the common way to tag it like that. (Even more for gatvė: 82370 times g. and 620 times gatvė

But it's undocumented... So filing this issue with JOSM would get the issue closed instantly. I'd recommend at least starting to document it on the wiki that in Lithuania the global rule isn't used (with a link to the community forum where it's discussed of course). You can add it to the exceptions here: https://wiki.openstreetmap.org/wiki/Abbreviations#Regional_variations